Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of several SE recipes and some minor fixes #5401

Merged
merged 2 commits into from Aug 16, 2023
Merged

Conversation

Emrys365
Copy link
Collaborator

@Emrys365 Emrys365 commented Aug 9, 2023

What?

This PR updates the bash scripts in several SE recipes to make them easier to use and fixes some potential bugs that might be difficult to detect.

@sw005320 sw005320 added this to the v.202312 milestone Aug 9, 2023
@sw005320
Copy link
Contributor

sw005320 commented Aug 9, 2023

@LiChenda, can you review this PR?

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #5401 (fb9d672) into master (3a82677) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #5401      +/-   ##
==========================================
- Coverage   77.19%   77.19%   -0.01%     
==========================================
  Files         679      679              
  Lines       61703    61709       +6     
==========================================
+ Hits        47630    47634       +4     
- Misses      14073    14075       +2     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.73% <ø> (ø)
test_integration_espnet2 48.54% <66.66%> (+<0.01%) ⬆️
test_python_espnet1 20.26% <0.00%> (-0.01%) ⬇️
test_python_espnet2 52.08% <0.00%> (-0.01%) ⬇️
test_utils 23.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
espnet2/bin/enh_tse_inference.py 90.43% <66.66%> (-0.59%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@LiChenda LiChenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@sw005320 sw005320 merged commit db4c5bc into espnet:master Aug 16, 2023
25 of 26 checks passed
@sw005320
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants