Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESPnet-SPk: major update #5408

Merged
merged 142 commits into from
Nov 8, 2023
Merged

ESPnet-SPk: major update #5408

merged 142 commits into from
Nov 8, 2023

Conversation

Jungjee
Copy link
Contributor

@Jungjee Jungjee commented Aug 12, 2023

What?

This PR combines several previous working PRs with new functions.

  • ESPnet-spk: add more model architectures #5385, ESPnet-SPK: add inference #5398
    This PR newly introduces:

  • Speed perturbation as speaker augmentation

  • Frontend design modification -> we now can train the model with frozen/free SSL front-ends through S3PRL

  • Additional Speaker models: ECAPA-TDNN and MFA-Conformer

  • Adds novel on-going research on representation learning

  • Inference stage, a separate inference stage for evaluating models with EER and minDCF.

  • (updated) Supported configurations

    • RawNet3 - EER 0.73% on Vox1-O
    • ECAPA-TDNN w/ mel-spectrogram - EER 0.96% on Vox1-O
    • ECAPA-TDNN w/ fixed WavLM-Large frontend - EER 0.60% on Vox1-O

Why?

We have been adding several new features.
Several ongoing PRs have conflicts in places.

See also

@Jungjee Jungjee closed this Nov 2, 2023
@Jungjee Jungjee reopened this Nov 2, 2023
@Jungjee Jungjee closed this Nov 2, 2023
@Jungjee Jungjee reopened this Nov 2, 2023
@Jungjee Jungjee closed this Nov 2, 2023
@Jungjee Jungjee reopened this Nov 2, 2023
@Jungjee Jungjee closed this Nov 2, 2023
@Jungjee Jungjee reopened this Nov 2, 2023
@Jungjee Jungjee closed this Nov 2, 2023
@Jungjee Jungjee reopened this Nov 2, 2023
@Jungjee Jungjee closed this Nov 2, 2023
@Jungjee Jungjee reopened this Nov 2, 2023
@Jungjee Jungjee closed this Nov 2, 2023
@Jungjee Jungjee reopened this Nov 2, 2023
@Jungjee Jungjee closed this Nov 2, 2023
@Jungjee Jungjee reopened this Nov 2, 2023
@Jungjee
Copy link
Contributor Author

Jungjee commented Nov 2, 2023

test_python seems to have timeout errors randomly (maybe better to increase timeout threshold?).
ci on windows / check_installable_on_windows suddenly started to fail.

currently I'm just closing and reopening..

@Jungjee Jungjee closed this Nov 2, 2023
@Jungjee Jungjee reopened this Nov 2, 2023
@sw005320
Copy link
Contributor

sw005320 commented Nov 3, 2023

@Emrys365, we still observe an issue in https://github.com/espnet/espnet/actions/runs/6738909252/job/18319405795?pr=5408#step:9:694
Can you check it?

@Jungjee
Copy link
Contributor Author

Jungjee commented Nov 3, 2023

@Emrys365, we still observe an issue in https://github.com/espnet/espnet/actions/runs/6738909252/job/18319405795?pr=5408#step:9:694 Can you check it?

These errors seem to be coming from the files/unittests that wasn't edited in this pr.

Maybe the update here (4c96187) is the reason?

@Emrys365
Copy link
Collaborator

Emrys365 commented Nov 3, 2023

Interesting. I thought fixing the input in my PR should avoid this issue. I will look at it later.

@sw005320 sw005320 added the auto-merge Enable auto-merge label Nov 8, 2023
@mergify mergify bot merged commit d624be0 into espnet:master Nov 8, 2023
24 of 25 checks passed
@Jungjee Jungjee deleted the spk_major_update branch November 8, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enable auto-merge CI Travis, Circle CI, etc ESPnet2 New Features README SID Speaker identification/embedding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants