New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for the JOSS paper editor review #5418
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5418 +/- ##
==========================================
+ Coverage 72.72% 77.17% +4.45%
==========================================
Files 679 684 +5
Lines 61692 62686 +994
==========================================
+ Hits 44865 48379 +3514
+ Misses 16827 14307 -2520
Flags with carried forward coverage won't be shown. Click here to find out more. see 80 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@neillu23 Thanks, the changes look good to me |
@Emrys365 Hi 👋. Would it be possible to review this PR soon so that we can continue with the JOSS publication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@faroit Sorry for my late response! I approve the above comments with some formatting suggestions. |
@Emrys365, how about committing your suggestions by yourself (They look good to me)? |
OK, I have committed the changes. |
@Emrys365 I appreciate your assistance! My apologies for overlooking your earlier remarks. |
What?
Why?
To address the comments from editor review #5399 for the JOSS paper "Software Design and User Interface of ESPnet-SE++: Speech Enhancement for Robust Speech Processing"