Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for the JOSS paper editor review #5418

Merged
merged 6 commits into from Sep 29, 2023
Merged

Conversation

neillu23
Copy link
Contributor

What?

  1. Add references to the actual model architecture papers as the paper mentions that espnet-se++ adds "several new models, loss functions, and training recipes".
  2. Add DOIs for the references. This is required for a JOSS publication
  3. Modify title={Onssen: an open-source ...} to title={{ONSSEN}: an open-source ...}

Why?

To address the comments from editor review #5399 for the JOSS paper "Software Design and User Interface of ESPnet-SE++: Speech Enhancement for Robust Speech Processing"

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #5418 (15fc598) into master (5d0758e) will increase coverage by 4.45%.
Report is 114 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5418      +/-   ##
==========================================
+ Coverage   72.72%   77.17%   +4.45%     
==========================================
  Files         679      684       +5     
  Lines       61692    62686     +994     
==========================================
+ Hits        44865    48379    +3514     
+ Misses      16827    14307    -2520     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.73% <ø> (ø)
test_integration_espnet2 49.07% <ø> (?)
test_python_espnet1 19.94% <ø> (-0.33%) ⬇️
test_python_espnet2 52.30% <ø> (+0.20%) ⬆️
test_utils 23.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 80 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320 sw005320 added this to the v.202312 milestone Aug 23, 2023
@sw005320 sw005320 requested a review from Emrys365 August 23, 2023 23:58
@faroit
Copy link

faroit commented Aug 25, 2023

@neillu23 Thanks, the changes look good to me

@sw005320 sw005320 added the auto-merge Enable auto-merge label Aug 30, 2023
@faroit
Copy link

faroit commented Sep 13, 2023

@Emrys365 Hi 👋. Would it be possible to review this PR soon so that we can continue with the JOSS publication

Copy link
Collaborator

@Emrys365 Emrys365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

doc/paper/espnet-se++/paper.bib Outdated Show resolved Hide resolved
doc/paper/espnet-se++/paper.bib Outdated Show resolved Hide resolved
doc/paper/espnet-se++/paper.bib Outdated Show resolved Hide resolved
doc/paper/espnet-se++/paper.bib Outdated Show resolved Hide resolved
doc/paper/espnet-se++/paper.bib Outdated Show resolved Hide resolved
doc/paper/espnet-se++/paper.bib Outdated Show resolved Hide resolved
doc/paper/espnet-se++/paper.bib Outdated Show resolved Hide resolved
doc/paper/espnet-se++/paper.bib Outdated Show resolved Hide resolved
doc/paper/espnet-se++/paper.bib Outdated Show resolved Hide resolved
doc/paper/espnet-se++/paper.bib Outdated Show resolved Hide resolved
@Emrys365
Copy link
Collaborator

@faroit Sorry for my late response! I approve the above comments with some formatting suggestions.

@sw005320
Copy link
Contributor

@Emrys365, how about committing your suggestions by yourself (They look good to me)?
Then, we can merge this PR.

@Emrys365
Copy link
Collaborator

OK, I have committed the changes.

@Emrys365 Emrys365 merged commit af1c169 into espnet:master Sep 29, 2023
25 checks passed
@neillu23
Copy link
Contributor Author

neillu23 commented Oct 1, 2023

@Emrys365 I appreciate your assistance! My apologies for overlooking your earlier remarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants