Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error robustness of unit tests #5523

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

Emrys365
Copy link
Collaborator

@Emrys365 Emrys365 commented Nov 1, 2023

What?

This PR improves two unit tests to avoid occasional errors caused by numerical precision or randomness.

Why?

Sometimes we may observe errors as in https://github.com/espnet/espnet/actions/runs/6719461822/job/18261148245 which are essentially numerical issues. After the modifications in this PR, these errors should be avoided in most cases.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #5523 (eb6f93a) into master (389b9cd) will increase coverage by 0.00%.
Report is 11 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5523   +/-   ##
=======================================
  Coverage   75.43%   75.43%           
=======================================
  Files         711      711           
  Lines       65757    65757           
=======================================
+ Hits        49606    49607    +1     
+ Misses      16151    16150    -1     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 65.67% <ø> (ø)
test_integration_espnet2 48.51% <ø> (ø)
test_python_espnet1 19.03% <ø> (ø)
test_python_espnet2 51.61% <ø> (+<0.01%) ⬆️
test_utils 23.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sw005320 sw005320 added the CI Travis, Circle CI, etc label Nov 1, 2023
@sw005320 sw005320 added this to the v.202312 milestone Nov 1, 2023
@sw005320 sw005320 merged commit 0440d9b into espnet:master Nov 2, 2023
25 checks passed
@sw005320
Copy link
Contributor

sw005320 commented Nov 2, 2023

Thanks, @Emrys365!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Travis, Circle CI, etc ESPnet2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants