Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kaldi dependency in asr2 #5540

Merged
merged 5 commits into from
Nov 9, 2023
Merged

fix kaldi dependency in asr2 #5540

merged 5 commits into from
Nov 9, 2023

Conversation

ftshijt
Copy link
Collaborator

@ftshijt ftshijt commented Nov 9, 2023

Why?

Since we changed to our own utils and steps, we do not support default Kaldi installation anymore, so better to change asr2 symlink to utils/steps of our own.

@mergify mergify bot added the ESPnet2 label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #5540 (738bc24) into master (78e5a31) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5540   +/-   ##
=======================================
  Coverage   76.75%   76.75%           
=======================================
  Files         719      719           
  Lines       66429    66429           
=======================================
  Hits        50986    50986           
  Misses      15443    15443           
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 63.00% <ø> (ø)
test_integration_espnet2 50.14% <ø> (ø)
test_python_espnet1 19.10% <ø> (ø)
test_python_espnet2 52.60% <ø> (ø)
test_utils 22.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ftshijt ftshijt added Recipe ASR Automatic speech recogntion labels Nov 9, 2023
@ftshijt ftshijt added this to the v.202312 milestone Nov 9, 2023
@sw005320
Copy link
Contributor

sw005320 commented Nov 9, 2023

Thanks a lot.
Some scripts may use Kaldi commands, but they are not major. So, we can go with this modification to simplify the dependency.

Copy link
Collaborator

@simpleoier simpleoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ftshijt ftshijt merged commit efa3932 into espnet:master Nov 9, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion ESPnet2 Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants