Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor OWSM data prep bug #5607

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

juice500ml
Copy link
Member

@juice500ml juice500ml commented Dec 27, 2023

What?

Why?

  • Fixed typo: f"<args.tgt>" -> f"<{args.tgt}>"
  • Checked all the use cases of kaldi_to_whisper.py, but no script uses --tgt parameter, so no problem in OWSM v3 training. Nevertheless, fixed the bug to remove potential future bugs.
  • FYI, @jctian98 @pyf98

@mergify mergify bot added the ESPnet2 label Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c140c2) 76.54% compared to head (25cd078) 76.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5607   +/-   ##
=======================================
  Coverage   76.54%   76.54%           
=======================================
  Files         720      720           
  Lines       66639    66639           
=======================================
  Hits        51008    51008           
  Misses      15631    15631           
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 62.92% <ø> (ø)
test_integration_espnet2 50.10% <ø> (+0.01%) ⬆️
test_python_espnet1 19.08% <ø> (ø)
test_python_espnet2 52.39% <ø> (ø)
test_utils 22.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320 sw005320 added the Bugfix label Jan 4, 2024
@sw005320 sw005320 added this to the v.202312 milestone Jan 4, 2024
@sw005320 sw005320 merged commit 61a2551 into espnet:master Jan 4, 2024
27 checks passed
@sw005320
Copy link
Contributor

sw005320 commented Jan 4, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants