Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug by copying missing Kaldi scripts #5636

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

VicentCano
Copy link

@VicentCano VicentCano commented Jan 25, 2024

What?

Two scripts where added (egs2/TEMPLATE/asr1/utils/data/modify_speaker_info.sh and egs2/TEMPLATE/asr1/utils/data/internal/modify_speaker_info.py) by copying them from Kaldi's github:
https://github.com/kaldi-asr/kaldi/tree/21ae411fd46282726d893e53c05fef5baea64fef/egs/wsj/s5/utils/data

Why?

The recipe failed when using espnet run.sh because egs2/TEMPLATE/asr1/utils/data/modify_speaker_info.sh was missing. This script is a Kaldi script and, by doing a quick search in the espnet repository appears to be used in the espnet recipes for tedlium3, ami, chime6 and tedlium2.
The other script, egs2/TEMPLATE/asr1/utils/data/internal/modify_speaker_info.py, was added since it was required by the first one.

@mergify mergify bot added the ESPnet2 label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f1b9ce) 76.15% compared to head (c5e6f94) 76.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5636   +/-   ##
=======================================
  Coverage   76.15%   76.15%           
=======================================
  Files         743      743           
  Lines       69117    69117           
=======================================
  Hits        52635    52635           
  Misses      16482    16482           
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 62.92% <ø> (ø)
test_integration_espnet2 48.51% <ø> (+0.01%) ⬆️
test_python_espnet1 18.40% <ø> (ø)
test_python_espnet2 52.67% <ø> (ø)
test_utils 22.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320 sw005320 added this to the v.202312 milestone Jan 25, 2024
@sw005320 sw005320 added the auto-merge Enable auto-merge label Jan 25, 2024
@sw005320
Copy link
Contributor

Thanks a lot!
After the CI check, I'll merge it.

@VicentCano
Copy link
Author

VicentCano commented Jan 25, 2024

Thank you @sw005320!

The CI check failed at test/espnet2/text/test_whisper_token_id_converter.py.
This error doesn't seem directly related to the scripts I added.
I have noticed the same error occurs in the CI check of #5623...

@VicentCano
Copy link
Author

Previous CI bug seems to be fixed with the latest commit. Thank you! Another unrelated error seems to apper in CI, this time while executing a HTTP request related to vits :(.

@mergify mergify bot merged commit 7bcb169 into espnet:master Jan 29, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants