Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TSE recipe egs2/librimix/tse1 #5731

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

Emrys365
Copy link
Collaborator

@Emrys365 Emrys365 commented Apr 4, 2024

What?

This PR addressed existing issues/bugs in the TSE recipe: egs2/librimix/tse1

Why?

See #5728

@Emrys365 Emrys365 added Bugfix SE Speech enhancement labels Apr 4, 2024
@mergify mergify bot added the ESPnet2 label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.15%. Comparing base (fd9db8f) to head (5d07303).
Report is 1 commits behind head on master.

❗ Current head 5d07303 differs from pull request most recent head 038de87. Consider uploading reports for the commit 038de87 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5731       +/-   ##
===========================================
- Coverage   76.73%   23.15%   -53.59%     
===========================================
  Files         761      758        -3     
  Lines       69703    69805      +102     
===========================================
- Hits        53490    16163    -37327     
- Misses      16213    53642    +37429     
Flag Coverage Δ
test_integration_espnet1 62.92% <ø> (ø)
test_integration_espnet2 ?
test_integration_espnetez ?
test_python_espnet1 18.20% <ø> (-0.05%) ⬇️
test_python_espnet2 ?
test_python_espnetez ?
test_utils ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320 sw005320 added this to the v.202405 milestone Apr 4, 2024
@sw005320
Copy link
Contributor

sw005320 commented Apr 5, 2024

Thanks!
This must be fine, but we have a big PR #5724 for the format change.
So, after #5724 is merged, I'll merge this.

@sw005320 sw005320 added the auto-merge Enable auto-merge label Apr 8, 2024
@mergify mergify bot merged commit f6f011d into espnet:master Apr 9, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enable auto-merge Bugfix ESPnet2 SE Speech enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants