Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing data.sh in OWSM #5750

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Fix failing data.sh in OWSM #5750

merged 2 commits into from
Apr 22, 2024

Conversation

cifkao
Copy link
Contributor

@cifkao cifkao commented Apr 22, 2024

What?

Theegs2/owsm_v1/s2t1/local/data.sh script is exiting for every dataset: ./local/prepare_${dataset}.sh || echo "preparing ${dataset} failed" gets executed first and always evaluates to true, so exit 1 will always get executed. I grouped the echo and the exit to fix this.

@pyf98

@mergify mergify bot added the ESPnet2 label Apr 22, 2024
@sw005320 sw005320 added Bugfix OWSM Open Whisper-style Speech Model labels Apr 22, 2024
@sw005320
Copy link
Contributor

Thanks!

@sw005320 sw005320 added the auto-merge Enable auto-merge label Apr 22, 2024
@mergify mergify bot merged commit 21cc547 into espnet:master Apr 22, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enable auto-merge Bugfix ESPnet2 OWSM Open Whisper-style Speech Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants