Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specaug.py #5803

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Update specaug.py #5803

merged 1 commit into from
Jun 10, 2024

Conversation

aky15
Copy link
Contributor

@aky15 aky15 commented Jun 6, 2024

What?

Support configuration and control of the methods of applying time and freq mask, i.e. masking with 0 or masking with the mean value. Masking with 0 by default.

Why?

Helps to switch the methods of applying time and freq mask.

Support configuration and control of the methods of applying time and freq mask, i.e. masking with 0 or masking with the mean value. Masking with 0 by default.
@mergify mergify bot added the ESPnet2 label Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.59%. Comparing base (b0e10d7) to head (444d52a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5803       +/-   ##
===========================================
+ Coverage   32.16%   54.59%   +22.43%     
===========================================
  Files         773      771        -2     
  Lines       70997    70732      -265     
===========================================
+ Hits        22835    38616    +15781     
+ Misses      48162    32116    -16046     
Flag Coverage Δ
test_integration_espnet2 ?
test_python_espnet2 52.98% <ø> (?)
test_python_espnetez ?
test_utils 20.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320
Copy link
Contributor

sw005320 commented Jun 6, 2024

Thanks.
I see that you have prepared the flag.
Will you prepare the option argument to replace the value?

@aky15
Copy link
Contributor Author

aky15 commented Jun 7, 2024

Yes, I add the default value True to make 'replace_with_zero' an option argument. @sw005320
Masking with 0 or by mean value has already been implemented in mask_along_axis function. However, the flag is missed in the SpecAug so I added it.

@sw005320
Copy link
Contributor

sw005320 commented Jun 7, 2024

Oh, I see.
Do you mean that the default behavior would be changed with this?

@pyf98, can you check this PR?

@pyf98
Copy link
Collaborator

pyf98 commented Jun 7, 2024

Thanks for adding the option. @aky15 I guess it won't change the default behavior? If this is true, then it looks good.

@aky15
Copy link
Contributor Author

aky15 commented Jun 9, 2024

Yes, it won't change the default behavior. @sw005320 @pyf98

@sw005320
Copy link
Contributor

OK, thanks!

@sw005320 sw005320 merged commit 128d307 into espnet:master Jun 10, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants