-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a speech enhancement recipe: egs2/urgent24/enh1 #5810
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5810 +/- ##
===========================================
+ Coverage 32.16% 62.62% +30.46%
===========================================
Files 773 153 -620
Lines 70997 17008 -53989
===========================================
- Hits 22835 10651 -12184
+ Misses 48162 6357 -41805
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Will you add a README file? Also, the CI error happens. Can you check it? (but it does not seem to be related to this PR.) |
Sure. I will add one after I get the baseline result. |
log "stage 2: Data preparation" | ||
|
||
cd "${odir}"/urgent2024_challenge | ||
./prepare_espnet_data.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file already in this commit? I can't find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is from the cloned repository. It's created before this stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @Emrys365 , I left some comments in the data preparation section.
cd "${odir}"/urgent2024_challenge | ||
./prepare_espnet_data.sh | ||
cd "${cwd}" | ||
cp -r "${odir}"/urgent2024_challenge/data "${PWD}/data" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cp
copy a lot of audio files? if so, maybe use ln
or mv
will be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be fine. There are only scp files in the directory.
Thanks, @Emrys365! |
What?
This PR adds a speech enhancement recipe for the URGENT 2024 Challenge.
Why?
This is an official recipe for the URGENT 2024 Challenge.
See also
https://urgent-challenge.github.io/urgent2024/baseline/