Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a speech enhancement recipe: egs2/urgent24/enh1 #5810

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

Emrys365
Copy link
Collaborator

@Emrys365 Emrys365 commented Jun 9, 2024

What?

This PR adds a speech enhancement recipe for the URGENT 2024 Challenge.

Why?

This is an official recipe for the URGENT 2024 Challenge.

See also

https://urgent-challenge.github.io/urgent2024/baseline/

@Emrys365 Emrys365 added Recipe ESPnet2 SE Speech enhancement labels Jun 9, 2024
@mergify mergify bot added the README label Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.62%. Comparing base (b0e10d7) to head (0369861).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5810       +/-   ##
===========================================
+ Coverage   32.16%   62.62%   +30.46%     
===========================================
  Files         773      153      -620     
  Lines       70997    17008    -53989     
===========================================
- Hits        22835    10651    -12184     
+ Misses      48162     6357    -41805     
Flag Coverage Δ
test_integration_espnet1 62.62% <ø> (?)
test_integration_espnet2 ?
test_python_espnetez ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sw005320
Copy link
Contributor

Will you add a README file?

Also, the CI error happens. Can you check it? (but it does not seem to be related to this PR.)

@Emrys365
Copy link
Collaborator Author

Sure. I will add one after I get the baseline result.

log "stage 2: Data preparation"

cd "${odir}"/urgent2024_challenge
./prepare_espnet_data.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file already in this commit? I can't find it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is from the cloned repository. It's created before this stage.

Copy link
Contributor

@LiChenda LiChenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Emrys365 , I left some comments in the data preparation section.

cd "${odir}"/urgent2024_challenge
./prepare_espnet_data.sh
cd "${cwd}"
cp -r "${odir}"/urgent2024_challenge/data "${PWD}/data"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cp copy a lot of audio files? if so, maybe use ln or mv will be better.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fine. There are only scp files in the directory.

@sw005320 sw005320 merged commit 293c1cc into espnet:master Jun 13, 2024
35 checks passed
@sw005320
Copy link
Contributor

Thanks, @Emrys365!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants