Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytorch for chainer v6.0.0 #772

Merged
merged 2 commits into from May 29, 2019
Merged

Conversation

Fhrozen
Copy link
Member

@Fhrozen Fhrozen commented May 29, 2019

The corrections for pytorch with chainer v6.0.0 are included in this PR, to solve #760.

  • Modified LMTest; this returned gpuid as a GPUId class, set self.device inside init
  • Replaced extensions.snapshot_object for (custom) snapshot_object. V6.0.0 call first serialize and the use the savefun method (not sure why it does this), so the training will raise error due to the lack of serialize routine. While v5.0.0 is straight. Just copied the required code into the 'asr_utils' and replace the line in 'pytorch/asr/train' and 'pytorch/tts/train'.

I did not find any additional problem for pytorch with chainer v6.0.0 and lm_train, asr_train, asr_decode, and tts_train worked well.
I suppose #761 will no longer be required to merge.

@sw005320 sw005320 requested a review from jnishi May 29, 2019 10:13
@sw005320
Copy link
Contributor

@Fhrozen
Copy link
Member Author

Fhrozen commented May 29, 2019

I just modified the last one (asr_mix) for pytorch. In case of chainer, this does not have any problem.

@sw005320 sw005320 merged commit da35de7 into espnet:v.0.4.0 May 29, 2019
@sw005320
Copy link
Contributor

Thanks, @Fhrozen!

@jnishi
Copy link
Contributor

jnishi commented May 29, 2019

Thanks. LGTM!

@Fhrozen Fhrozen deleted the pr-fix-chainer6 branch May 30, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants