Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support new version in Docker containers #836

Merged
merged 6 commits into from Jun 18, 2019

Conversation

Fhrozen
Copy link
Member

@Fhrozen Fhrozen commented Jun 13, 2019

I just finish to build the containers with the new fixes in warp-ctc and chainer-ctc (Details at #733)
The containers are been uploaded to the hub and then test on a PC with RTX 2080Ti and CUDA 10.1.
The server with V100 is been used so not sure when will be available.
Once the tests on RTX are done the [WIP] will be remove and this little PR will be ready to merge.

@Fhrozen
Copy link
Member Author

Fhrozen commented Jun 13, 2019

Tests finished. RTX with CUDA 10.1 now is working with and observation that the pytorch backend is still not supported. I tested a docker container with pytorch 1.0.1 and it has not problem. So suppose that this error will be resolve when v.0.4.0 is merged.

@Fhrozen Fhrozen changed the title [WIP] Updating docker containers Updating docker containers Jun 13, 2019
@Fhrozen Fhrozen changed the title Updating docker containers [WIP] Support new version in Docker containers Jun 15, 2019
@sw005320 sw005320 added this to the v.0.4.1 milestone Jun 15, 2019
@sw005320 sw005320 added the Enhancement Enhancement label Jun 15, 2019
@Fhrozen
Copy link
Member Author

Fhrozen commented Jun 18, 2019

@sw005320 I just finish to build and test a docker container with ubuntu 18.04 and cuda 10.0 without problem.
Some of the library from runtime has been remove given that they are no longer required.
Also, I tried to keep the same building route as NVIDIA and for ubuntu 18.04, the containers are built for CUDA versions 9.2, 10.0, and 10.1. So the number of container will be reduced to only 4 (3 by the moment) cpu and the versions detailed previously.

Let me know if there is any possible trouble with this.
The recipes are ready so once you give the confirmation I will build them and push in to the Hub, and this PR will be ready to merge.

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #836 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #836   +/-   ##
=======================================
  Coverage   50.39%   50.39%           
=======================================
  Files          88       88           
  Lines        9739     9739           
=======================================
  Hits         4908     4908           
  Misses       4831     4831

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97da2da...c8de7c5. Read the comment docs.

@sw005320 sw005320 merged commit e227388 into espnet:master Jun 18, 2019
@Fhrozen Fhrozen deleted the pr-docker branch June 23, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants