Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sdist installation #2

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

dvjn
Copy link
Contributor

@dvjn dvjn commented Oct 2, 2020

Fixes #1

Please, could you merge this and create a new release.
I need to use this in my project, would be helpful.

Thank You!

dvjn and others added 2 commits October 2, 2020 23:34
Moved the content of __main__.py to the new module cli.py
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@espositoandrea
Copy link
Owner

Again, thanks for your time. As I've already explained in #1, I moved the __main__.py file's content to cli.py in order to keep the imports meaningful, just in case someone wants to use this tool as a library.

I'm merging this PR and uploading the new version to PyPI. Just one small note: this is a very basic tool that needs further development in order to be used seriously in a project. Feel free to extend the recognized commands with whatever you may need 😄.

@espositoandrea espositoandrea merged commit 13e79c6 into espositoandrea:master Oct 2, 2020
@dvjn
Copy link
Contributor Author

dvjn commented Oct 3, 2020

I moved the __main__.py file's content to cli.py in order to keep the imports meaningful

I was going to do that but was afraid of seeming too rude/confrontational by making any major changes.

Just one small note: this is a very basic tool that needs further development in order to be used seriously in a project. Feel free to extend the recognized commands with whatever you may need.

  1. We could discuss some enhancements, in separate issues or something?
  2. Should I put a series of enhancement PRs if I feel some features are required?
  3. Are you open to some opinionated PRs, or should I refrain from those? (which is perfectly fine)

Also if you wanted to implement some features, put a TODO or Roadmap (in a pinned issue or something?), I'd love to help!

BTW, thanks for the amazing library, I was using it as a dev requirement in my library importit. I am too lazy to write commands in both Makefile and make.bat, I'd rather help you develop this project if I need some features.

@dvjn dvjn deleted the fix-sdist-install branch October 3, 2020 06:22
@espositoandrea
Copy link
Owner

I was going to do that but was afraid of seeming too rude/confrontational by making any major changes.

Not at all 😃!

  1. We could discuss some enhancements, in separate issues or something?

Yes, if the enhancements are on the architecture of this library, on its documentation, on the Makefile parsing, or in general in its codebase. If the modifications just aim at providing support for more commands, it's not necessary.

  1. Should I put a series of enhancement PRs if I feel some features are required?

If you're able to write the code yourself, feel free to do it!

  1. Are you open to some opinionated PRs, or should I refrain from those? (which is perfectly fine)

Absolutely yes! Just as long as we discuss the edits and the reason behind them, everything is fine! If you want, you can open an issue to discuss the edits first, so that you won't lose time in editing the code if there's a reason for the code being the way it is.

Also if you wanted to implement some features, put a TODO or Roadmap (in a pinned issue or something?), I'd love to help!

The main enhancement that this tool need is a larger set of recognized commands. For this reason, at the moment, there isn't a need for a structured TODO list.

As for the roadmap, I have some enhancements in mind: first of all the entirety of the code should be documented and "standardized" (at the moment, it doesn't use a virtualenv or industry's standards like Sphynx). I've actually recently reused this tool, and I've recognized some enhancement, but without proper documentation (on which I'm already working by the way) it's just painful to even think and implement the various edits. I'll work on the documentation and I'll publish a roadmap along with it!

BTW, thanks for the amazing library, I was using it as a dev requirement in my library importit. I am too lazy to write commands in both Makefile and make.bat, I'd rather help you develop this project if I need some features.

Thank you so much! I've created this tool 3-4 years ago because I was too lazy to convert Unix commands to Windows too! Every kind of help is gladly received!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes when installing from sdist, and colorama is not already installed
2 participants