Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SPI variant info work #271

Closed
ladyada opened this issue Mar 18, 2017 · 4 comments
Closed

Make SPI variant info work #271

ladyada opened this issue Mar 18, 2017 · 4 comments

Comments

@ladyada
Copy link
Contributor

ladyada commented Mar 18, 2017

hiya - testing that TFT code on the Feather! :) right now the SPI pins defined in the variant files aren't ever used - this tweak will fix so the defaults are used (the Feather ESP32 uses other pins for routing ease)

adafruit@d602169
@me-no-dev
Copy link
Member

Ha! I kinda wonder why I have not caught this :) You want to make a PR or? do you have more changes in your fork or is it otherwise synced with us?

@ladyada
Copy link
Contributor Author

ladyada commented Mar 18, 2017

do you mind hand-adding? its only two lines...(my fork got desynced pretty badly and i didn't manage the conflict right so i'll start fresh. whee git!)

@me-no-dev
Copy link
Member

Will add manually :) No problem, but one good thing of github is to track contributions :)

@me-no-dev
Copy link
Member

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ladyada @me-no-dev