Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HardwareSerial - add changeBaudRate method #2223

Merged
merged 3 commits into from
Dec 23, 2018
Merged

HardwareSerial - add changeBaudRate method #2223

merged 3 commits into from
Dec 23, 2018

Conversation

toomasz
Copy link
Contributor

@toomasz toomasz commented Dec 20, 2018 •
edited

  • This method will be useful for libraries that attempt to find current baud rate of device connected via Serial, for example GSM modems
  • Please be aware that some garbage on Serial may occur(an most of times it does) after baud rate is changed

Fixes:
#441

me-no-dev
me-no-dev reviewed Dec 23, 2018
View reviewed changes
cores/esp32/HardwareSerial.h Outdated
@@ -57,6 +57,7 @@ class HardwareSerial: public Stream

void begin(unsigned long baud, uint32_t config=SERIAL_8N1, int8_t rxPin=-1, int8_t txPin=-1, bool invert=false, unsigned long timeout_ms = 20000UL);
void end();
void updateBaudRate(unsigned long baud);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra tab?

@me-no-dev
Copy link
Member

One comment on style :) please fix and I will merge. I have an idea for the bad char.

@toomasz
Copy link
Contributor Author

toomasz commented Dec 23, 2018

@me-no-dev done

@me-no-dev me-no-dev merged commit 5af139b into espressif:master Dec 23, 2018
@me-no-dev
Copy link
Member

Thanks :)

@toomasz
Copy link
Contributor Author

toomasz commented Dec 23, 2018

No problem, could you close #441 also?

@toomasz toomasz mentioned this pull request Dec 23, 2018
Closed
@toomasz toomasz deleted the update_baud_rate branch December 23, 2018 20:20
@toomasz toomasz mentioned this pull request Jan 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@toomasz @me-no-dev