Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64::encode : const correctness / String by reference passing #3314

Merged
merged 2 commits into from Oct 2, 2019

Conversation

@dirkmueller
Copy link
Contributor

commented Oct 2, 2019

Avoid passing String by-value, which is slightly less efficient
as it involves a full copy-constructor/tempstring creation.

dirkmueller and others added 2 commits Oct 2, 2019
Avoid passing String by-value, which is slightly less efficient
as it involves a full copy-constructor/tempstring creation.
@me-no-dev me-no-dev merged commit 6f70e27 into espressif:master Oct 2, 2019
21 checks passed
21 checks passed
Arduino 0 on ubuntu-latest
Details
Arduino 1 on ubuntu-latest
Details
Arduino 2 on ubuntu-latest
Details
Arduino 3 on ubuntu-latest
Details
Arduino 4 on ubuntu-latest
Details
Arduino 5 on ubuntu-latest
Details
Arduino 6 on ubuntu-latest
Details
Arduino 7 on ubuntu-latest
Details
Arduino 8 on ubuntu-latest
Details
Arduino 9 on ubuntu-latest
Details
Arduino 10 on ubuntu-latest
Details
Arduino 11 on ubuntu-latest
Details
Arduino 12 on ubuntu-latest
Details
Arduino 13 on ubuntu-latest
Details
Arduino 14 on ubuntu-latest
Details
Arduino on windows-latest
Details
Arduino on macOS-latest
Details
PlatformIO on ubuntu-latest
Details
PlatformIO on windows-latest
Details
PlatformIO on macOS-latest
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@me-no-dev

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Thanks :) totally agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.