Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LITTLEFS after esp_littlefs (IDF) is built-in #4483

Merged
merged 7 commits into from
Nov 3, 2020
Merged

Adding LITTLEFS after esp_littlefs (IDF) is built-in #4483

merged 7 commits into from
Nov 3, 2020

Conversation

lorol
Copy link
Contributor

@lorol lorol commented Nov 3, 2020

@me-no-dev
Copy link
Member

please pull the latest change. it's required to make CI work :)

@me-no-dev me-no-dev merged commit cf60cf4 into espressif:esp32s2 Nov 3, 2020
@lorol
Copy link
Contributor Author

lorol commented Nov 3, 2020

Great. Now testing, feedback and tools mess.

@lorol
Copy link
Contributor Author

lorol commented Nov 4, 2020

@me-no-dev
It looks like to suppress the B110 and B1000000 redefining warnings. #undeff's should be after #include "vfs_api.h" and before #include "esp_littlefs.h".
I guess the easiest way is just you to correct directly on next commit instead of PR only for that?

#include "vfs_api.h"

extern "C" {
#include <sys/unistd.h>
#include <sys/stat.h>
#include <dirent.h>
  <<< undefs to be moved here 
#include "esp_littlefs.h"
#undef B110
#undef B1000000
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants