Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esp32 s3 support #6341

Merged
merged 67 commits into from
Mar 28, 2022
Merged

Esp32 s3 support #6341

merged 67 commits into from
Mar 28, 2022

Conversation

me-no-dev
Copy link
Member

No description provided.

me-no-dev and others added 30 commits January 21, 2022 00:43
Just so we can compile and test! Some things might/will not work. SPI and UART baud detect need to be looked at.
When passing the PR to this branch, it seems that the change to this line was forgotten.
Basic version of Arduino's I2S library. We currently support only 16bps + 16000 Hz sampling frequency. Other bitrates and sample rates will print warning and continue to operate, however the resulting audio quality may be poor.
There will be further effort to fix these issues.
@me-no-dev me-no-dev removed the hil_test Run Hardware Tests label Mar 10, 2022
@Ouss4
Copy link
Contributor

Ouss4 commented Mar 10, 2022

@Ouss4 seems that S3 is not yet supported in hardware: https://github.com/espressif/arduino-esp32/runs/5498592665?check_suite_focus=true#step:7:48

It's pytest-embedded that's missing an S3 chip. I'll submit a PR.
This espressif/pytest-embedded#68 should do.

@VojtechBartoska
Copy link
Collaborator

VojtechBartoska commented Mar 23, 2022

In this PR is included commit which will Close #5864 and #6187

@VojtechBartoska VojtechBartoska mentioned this pull request Mar 23, 2022
2 tasks
me-no-dev and others added 2 commits March 25, 2022 03:33
Includes support for SDMMC, LCD, LEDs, Buttons, Power and USB Switch
* feather esp32-s3 hardware definition and bootloader

* fix bootloader addr (!?)

* fix esp32s2 bootloader to latest version with right url and favvvvvicon

* add qt py, simplify menus by removing flash size (fixed 8mb), psram (disabled) and upload (usb mode only)

* add qtpy variant

* remove flash interface type (upload dio, boot qio)

* finish qtpy s3 definition
@me-no-dev me-no-dev merged commit 8ee5f0a into master Mar 28, 2022
@me-no-dev me-no-dev deleted the esp32-s3-support branch March 28, 2022 09:09
@chatfrog
Copy link

Have you really tested your code? I tested almost all examples, they could not pass compiling process. I tried Arduino IDE 1.8 and 2.0 separately with latest arduino ESP32 core 2.07 and 2.04.

@ConstantinCreations
Copy link

I don't see how this code can possibly work with the ESP32-S3. You need to specify I2S pins for the S3 since there are no defaults. You can use almost any pin you want for I2S on an ESP32-S3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chip: ESP32-S3 Issue is related to support of ESP32-S3 Chip Type: Chip support
Projects
Development

Successfully merging this pull request may close these issues.

None yet