Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full setsocketoption to WifiClient and WifiClientSecure #7030

Merged
merged 6 commits into from Aug 8, 2022
Merged

Add full setsocketoption to WifiClient and WifiClientSecure #7030

merged 6 commits into from Aug 8, 2022

Conversation

20162026
Copy link

Description of Change

Adds full setsockopt method to WifiClient and WifiClientSecure as the previous implementation did not allow selection of option level, e.g. no way to change IPPROTO_TCP options for WifiClientSecure.

Tests scenarios

tested with wroom32e based custom board, feature is backward compatible and should not break anything

Related links

workaround for #6997

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@VojtechBartoska VojtechBartoska added the Area: BT&Wifi BT & Wifi related issues label Jul 25, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jul 26, 2022
@VojtechBartoska VojtechBartoska added this to the 2.0.5 milestone Jul 27, 2022
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @20162026 for PR

@SuGlider
Copy link
Collaborator

SuGlider commented Aug 1, 2022

@20162026 - Should merging this PR close #6997? It seems good for merging.

@20162026
Copy link
Author

20162026 commented Aug 2, 2022

@SuGlider this PR will not solve #6997 by itself , it will just give user a possibility to modify TCP_KEEPIDLE as a workaround

SuGlider
SuGlider approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuGlider SuGlider merged commit cb3ffd0 into espressif:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: BT&Wifi BT & Wifi related issues
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@20162026 @CLAassistant @SuGlider @P-R-O-C-H-Y @VojtechBartoska