Add new board: RedPill ESP32S3. #7523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
P-R-O-C-H-Y
requested changes
Dec 2, 2022
There was a problem hiding this comment.
@razvan-mocanu PTAL on my comment. Overall looks good and can be merged after this little suggested change.
P-R-O-C-H-Y
added
the
Resolution: Awaiting response
P-R-O-C-H-Y
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add a new board based on ESP32S3 WROOM-1.
Tests scenarios
RedPill ESP32S3 board and Arduino IDE 2.0.2. With the provided definition, the board is displayed in the list of boards. Once selected, the definitions for this board can be used.
Related links
Board details: https://munich-labs.com/index.php/redpill-esp32-s3/