Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newly boards (Deneyap Kart 1A v2, Deneyap Mini v2) #7603

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Add newly boards (Deneyap Kart 1A v2, Deneyap Mini v2) #7603

merged 3 commits into from
Dec 21, 2022

Conversation

zeynepdicle
Copy link
Contributor

Description of Change

Add newly boards

  • Deneyap Mini v2 (ESP32-S2)
  • Deneyap Kart 1A v2 (ESP32-S3)

Update pin_arduino.h and boardds.txt files for Deneyap Boards

  • Deneyap Kart (ESP32)
  • Deneyap Kart 1A (ESP32)
  • Deneyap Mini (ESP32-S2)
  • Deneyap Kart G (ESP32-C3)

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v2.0.5 v2.0.4 with ESP32 and Deneyap-Arduino-core v1.3.9 with this scenarios.

Related links

Official website: https://deneyapkart.org/en/
Documents: https://docs.deneyapkart.org/en/
Forum: https://forum.deneyapkart.org/
Github: https://github.com/deneyapkart

(eg. Closes #number of issue)

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Dec 20, 2022
@P-R-O-C-H-Y
Copy link
Member

Hi @zeynepdicle , I saw some recent changes in previous closed PR. Are these changes final for now? :)

@zeynepdicle
Copy link
Contributor Author

zeynepdicle commented Dec 20, 2022 •
edited

Hi @zeynepdicle , I saw some recent changes in previous closed PR. Are these changes final for now? :)

Hi @P-R-O-C-H-Y , Yes these are final changes :)

P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zeynepdicle, please take a look on my comments :) once everything is fixed it can be merged 👍

variants/deneyapkart/pins_arduino.h Outdated Show resolved Hide resolved
variants/deneyapkart1A/pins_arduino.h Outdated Show resolved Hide resolved
variants/deneyapkartg/pins_arduino.h Show resolved Hide resolved
variants/deneyapkartg/pins_arduino.h Outdated Show resolved Hide resolved
variants/deneyapkart1Av2/pins_arduino.h Outdated Show resolved Hide resolved
variants/deneyapmini/pins_arduino.h Outdated Show resolved Hide resolved
variants/deneyapminiv2/pins_arduino.h Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
@P-R-O-C-H-Y P-R-O-C-H-Y added the Resolution: Awaiting response Waiting for response of author label Dec 21, 2022
@zeynepdicle
Copy link
Contributor Author

Hi again @P-R-O-C-H-Y :) I fixed it, any problem?

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeynepdicle Thanks for quick fixes :) Will merge after CI passes.

@zeynepdicle
Copy link
Contributor Author

zeynepdicle commented Dec 21, 2022 •
edited

@zeynepdicle Thanks for quick fixes :) Will merge after CI passes.

@P-R-O-C-H-Y thank you too :)

@P-R-O-C-H-Y P-R-O-C-H-Y merged commit e69081c into espressif:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Resolution: Awaiting response Waiting for response of author Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zeynepdicle @P-R-O-C-H-Y @VojtechBartoska