Removes a few Warnings and fixes Math rand() to work like Arduino mainstream #7613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is part of a work to clean up Warnings from the core. The flags below are not necessary anymore:
But we still need
-Wno-unused-parameter
because IDF inline declarations use some parameters that are not used dependening on#define
This PR also fixes Math rand(negative parameter) in order to make it work exactly as it does in Arduino mainstream.
Tests scenarios
Tested with ESP32 WROVER-E, using a modified
platform.txt
with this change:Related links
It is a pre requisite for merging #7060