Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing ESP32-D0WDR2-V3 added to getChipModel() #7958

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

pswid
Copy link
Contributor

@pswid pswid commented Mar 13, 2023

Tested on ESP32-D0WDR2-V3 chip. It is now correctly detected by getChipModel().

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2023

CLA assistant check
All committers have signed the CLA.

@mrengineer7777
Copy link
Collaborator

mrengineer7777 commented Mar 13, 2023

LGTM

#define EFUSE_RD_CHIP_VER_PKG_ESP32D0WDQ6 0

Excerpt:

#define EFUSE_RD_CHIP_VER_PKG_ESP32D0WDQ6  0
#define EFUSE_RD_CHIP_VER_PKG_ESP32D0WDQ5  1
#define EFUSE_RD_CHIP_VER_PKG_ESP32D2WDQ5  2
#define EFUSE_RD_CHIP_VER_PKG_ESP32PICOD2  4 /* Deprecated: this chip was never mass produced  */
#define EFUSE_RD_CHIP_VER_PKG_ESP32U4WDH   4
#define EFUSE_RD_CHIP_VER_PKG_ESP32PICOD4  5
#define EFUSE_RD_CHIP_VER_PKG_ESP32PICOV302  6
#define EFUSE_RD_CHIP_VER_PKG_ESP32D0WDR2V3  7

At first I thought entry for EFUSE_RD_CHIP_VER_PKG_ESP32U4WDH was missing, but then I realized it's the same value as the deprecated PICO entry.

According to ESP32-U4WDH, that part is used in ESP32-MINI-1 modules.

Edit: ESP32-U4WDH was also used in WROOM, WROVER, etc modules, and is marked as NRND.

@pswid
Copy link
Contributor Author

pswid commented Mar 14, 2023

Thus, it remains unknown how ESP32-S0WD (singlecore chip) is detected. I'm afraid I don't have any module on this chip to check it.

What do you think about adjusting the names returned by getChipModel() to match the official Espressif datasheets? I'm talking about:
ESP32-D0WDQ5 -> ESP32-D0WD, ESP32-D2WDQ5 -> ESP32-D2WD and adding (based on the chip revision) ESP32-D0WD-V3 and ESP32-D0WDQ6-V3?

@mrengineer7777
Copy link
Collaborator

What do you think about adjusting the names returned by getChipModel() to match the official Espressif datasheets? I'm talking about: ESP32-D0WDQ5 -> ESP32-D0WD, ESP32-D2WDQ5 -> ESP32-D2WD and adding (based on the chip revision) ESP32-D0WD-V3 and ESP32-D0WDQ6-V3?

I'll have to wait for the developers to answer that one. That could have unexpected consequences.

@VojtechBartoska VojtechBartoska added Status: Review needed Issue or PR is awaiting review Status: Awaiting triage Issue is waiting for triage and removed Type: 3rd party Boards labels Mar 22, 2023
@me-no-dev me-no-dev merged commit 57b951a into espressif:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting triage Issue is waiting for triage Status: Review needed Issue or PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants