Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for large uploads to HTTPClient #8006

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Add support for large uploads to HTTPClient #8006

merged 1 commit into from
Mar 31, 2023

Conversation

me-no-dev
Copy link
Member

Partial duplicate of #7638

ekapujiw2002
ekapujiw2002 reviewed Mar 30, 2023
View reviewed changes
Copy link

@ekapujiw2002 ekapujiw2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is without yield() that while loop will not make esp soft reset?

@me-no-dev
Copy link
Member Author

Is without yield() that while loop will not make esp soft reset?

Will not, because write itself will yield internally.

@me-no-dev me-no-dev merged commit bad5af9 into master Mar 31, 2023
@me-no-dev me-no-dev deleted the bugfix/httpclient-large-uploads branch March 31, 2023 10:39
@me-no-dev me-no-dev mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekapujiw2002 ekapujiw2002 ekapujiw2002 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@me-no-dev @ekapujiw2002