Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated get.py with ability to verify extracted files and skip if ok #8496

Closed

Conversation

PilnyTomas
Copy link
Contributor

@PilnyTomas PilnyTomas commented Aug 7, 2023

New features:

  • Detects corrupted archives (for example not completely downloaded) and automatically re-downloads them (the corrupted archive is renamed with a suffix ".corrupted)
  • Detects incomplete extraction (checks only missing filenames - intentional corruption such as changing contents of files is not expected and not detected) - incomplete extraction triggers new and complete extraction
  • Updated download report to show download speed and elapsed time
  • New parameters:
    • '-v' Verbose - displays more info
    • '-d' Force download all archives (skipping checks)
    • '-e' Force extraction (skipping checks)
    • '-f' Force both download and extraction (skipping checks)

Test scenarios (only on Linux)

  • Fresh - nothing is downloaded, nothing is extracted
    • Time to complete: 2m51.901s
  • Downloaded - only full extraction
    • Time to complete: 1m22.337s
  • Already installed - only performing checks - nothing is missing
    • Time to complete: 0m45.402s
  • Multiple corruption - 1 missing archive, 1 archive not downloaded properly, 1 archive not extracted at all, 1 file missing
    • Handled without error or crashing - all tools installed

@PilnyTomas PilnyTomas self-assigned this Aug 10, 2023
@VojtechBartoska VojtechBartoska self-assigned this Aug 15, 2023
@me-no-dev me-no-dev marked this pull request as ready for review October 5, 2023 13:44
@me-no-dev me-no-dev marked this pull request as draft October 5, 2023 13:45
@me-no-dev
Copy link
Member

Closed in favor of: #8720

@me-no-dev me-no-dev closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants