Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI - fix attach pin for ESP32-S3 #8512

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR fixes attaching/detaching some of the SPI pins for S3. Probably a leftover when new chip was added.
In 5.1-libs branch, this part of code no longer exists, so no issue there.

Tests scenarios

checked agains variant if pins are correct.

Related links

Closes #8508

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Peripherals API Relates to peripheral's APIs. label Aug 11, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Aug 11, 2023
@me-no-dev me-no-dev changed the base branch from master to release/v2.x August 12, 2023 21:13
@me-no-dev me-no-dev merged commit 7d607bf into espressif:release/v2.x Aug 12, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Peripherals API Relates to peripheral's APIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32-S3 SPI spiAttach... spiDetach... function use wrong pins
3 participants