Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "WiFiSTA - allow using DHCP again after disconnecting static IP" #8873

Merged

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Nov 12, 2023

I want to revert my recent PR #8848

It turned out that all libraries I tested preserved the static IP settings over disconnect() (except my WiFiEspAT). I learned that the right way to return to DHCP is config(INADDR_NONE, INADDR_NONE, INADDR_NONE). And this really worked in all WiFi libraries.
So the user of the library can config the static IP and then disconnect and later begin again with the same static IP.

@SuGlider SuGlider self-assigned this Nov 26, 2023
@SuGlider SuGlider self-requested a review November 27, 2023 12:53
@mrengineer7777
Copy link
Collaborator

I can see setting _useStaticIp = false; if eraseap is set. Looks like there's a lot more history behind this change I'd have to understand.

@VojtechBartoska VojtechBartoska added Area: WiFi Issue related to WiFi Status: Review needed Issue or PR is awaiting review labels Nov 28, 2023
@VojtechBartoska VojtechBartoska added this to the 3.0.0-RC1 milestone Nov 28, 2023
Copy link
Contributor

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello JAndrassy, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4b72877

@VojtechBartoska VojtechBartoska added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Dec 20, 2023
@VojtechBartoska
Copy link
Collaborator

This PR is ready to be merged as an Revert.

@me-no-dev me-no-dev merged commit ad4f0ac into espressif:master Dec 20, 2023
46 checks passed
@JAndrassy JAndrassy deleted the revert_wifi_disconnect_usestaticip_false branch December 20, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: WiFi Issue related to WiFi Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants