Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes EspClass::deepSleep(64 bits) #9077

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Fixes EspClass::deepSleep(64 bits) #9077

merged 2 commits into from
Jan 8, 2024

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Jan 6, 2024

Description of Change

esp_deep_sleep(uint64_t time_in_us) takes a 64 bit argument, but void EspClass::deepSleep(uint32_t time_us) allows only 32 bit.

This fixes it, for a sleep time over 2,147 seconds (over 36 minutes).

https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/system/sleep_modes.html#_CPPv414esp_deep_sleep8uint64_t

Tests scenarios

Just CI.

Related links

Fixes #9074

This will change time in microseconds from 32 bits to 64 bits as defined in IDF.
@SuGlider SuGlider added this to the 3.0.0 milestone Jan 6, 2024
@SuGlider SuGlider self-assigned this Jan 6, 2024
@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label Jan 6, 2024
Copy link
Contributor

github-actions bot commented Jan 6, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Fixes EspClass::deepSleep(64 bits)":
    • summary looks empty
    • type/action looks empty
  • the commit message "updates function declaration":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️

The source branch "SuGlider-patch-2" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8a7f578

@SuGlider
Copy link
Collaborator Author

SuGlider commented Jan 6, 2024

@me-no-dev - Please merge this PR to release/v2.x branch too. Thanks!

@SuGlider SuGlider modified the milestones: 3.0.0, 3.0.0-RC1 Jan 6, 2024
@me-no-dev me-no-dev merged commit 73dd8a2 into master Jan 8, 2024
39 checks passed
@me-no-dev me-no-dev deleted the SuGlider-patch-2 branch January 8, 2024 12:00
me-no-dev pushed a commit that referenced this pull request Jan 8, 2024
* Fixes EspClass::deepSleep(64 bits)

This will change time in microseconds from 32 bits to 64 bits as defined in IDF.

* updates function declaration
@me-no-dev
Copy link
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

EspClass::deepSleep only accepts 32bit Integer instead of 64bit
2 participants