Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more keys in USBHIDKeyboard #9190

Merged
merged 1 commit into from Feb 1, 2024
Merged

Add more keys in USBHIDKeyboard #9190

merged 1 commit into from Feb 1, 2024

Conversation

andreock
Copy link
Contributor

Description of Change

I added some keys code in USBHIDKeyboard header file so it can be used in Keyboard.press()

Tests scenarios

I have tested the following change with framework arduino-esp32 2.0.11 using an ESP32-S3. The PC that I used for test, has installed nixOS 23.11 with kernel 6.1.75. All the keys added in this PR works in my test.

@andreock
feat(usb): Add more keys in USBHIDKeyboard
39b11fa 
* Add more keys value that can be used with Keyboard.press()
@github-actions GitHub Actions
Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello andreock, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 39b11fa

P-R-O-C-H-Y
P-R-O-C-H-Y reviewed Jan 30, 2024
View reviewed changes
libraries/USB/src/USBHIDKeyboard.h
@@ -63,6 +63,7 @@ typedef union {
#define KEY_DOWN_ARROW 0xD9
#define KEY_LEFT_ARROW 0xD8
#define KEY_RIGHT_ARROW 0xD7
#define KEY_MENU 0xFE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreock I am not sure about this one. Can you please post any docs where you get this from? Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it from here: https://github.com/msommacal/duckuino/blob/master/parser.y#L47

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested them?

Copy link
Contributor Author

@andreock andreock Jan 31, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I described it in PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@P-R-O-C-H-Y changes are OK with me

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Feb 1, 2024
@me-no-dev me-no-dev merged commit b163583 into espressif:master Feb 1, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andreock @me-no-dev @P-R-O-C-H-Y