Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spiTransaction not updating clock line immediately (#9221) #9333

Merged
merged 1 commit into from Mar 5, 2024

Conversation

and3rson
Copy link
Contributor

@and3rson and3rson commented Mar 4, 2024

Description of Change

This PR fixes #9221 by forcing SPI clock line to update within spiTransaction.
This is especially important when sharing a single SPI bus between devices with different SPI modes.
Notable use case is using SD card (SPI mode 0) and ST7789-based TFT display (mode 3).

Tests scenarios

Tested with ESP32-C3 SuperMini board.

Related links

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello and3rson, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5d9cfba

@lucasssvaz lucasssvaz added Area: Peripherals API Relates to peripheral's APIs. hil_test Run Hardware Tests labels Mar 4, 2024
@me-no-dev
Copy link
Member

Thanks @and3rson ! This is a nice solution

@me-no-dev me-no-dev merged commit 629ffc5 into espressif:master Mar 5, 2024
143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Peripherals API Relates to peripheral's APIs. hil_test Run Hardware Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPI.beginTransaction does not set SCK value until the first write
4 participants