backport: variants from 3.0.0 + fixes #9381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
|
overall looks OK, but hard to really find if there is something wrong :) |
P-R-O-C-H-Y
approved these changes
Mar 18, 2024
|
Also we may include board fixes from PR: Heltec ESP32 Series boards update #9367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backports changes from 3.0.0 to
variantsand fixes the "unphone8" wrong board definition.Only changes boards that were already in 2.0.14. No new board is added.
RGB_LED is now fixed for all boards with NEO LED.
The same for BUILTIN_LED. Both will work fine with
digitalWrite()andneo_pixel_write()Applied fixes done by the board makers in 3.0.0 based on PR #8726
Tests scenarios
Quick random testing with some boards.
Related links
Closes #9037