Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nano ESP32: delete programmer.default entry (on 2.0.x) #9665

Merged
merged 1 commit into from
May 22, 2024

Conversation

pillo79
Copy link
Contributor

@pillo79 pillo79 commented May 22, 2024

Description of Change

Recent debug support commits added the programmer.default entry for the Nano ESP32 on 2.0.x releases.

Setting that parameter has unfortunately multiple effects:

  • sets the tick by default in the Tools->Programmer menu in the IDE (which was the reason for the added line), but also...
  • forces the CLI to use the specified programmer every time an upload is attempted (which is confusing users, since they don't get the DFU upload they expect).

For this reason, it is better to remove the programmer.default setting from the board definition and let the user choose the programmer in the IDE menus, as it was before.

Tests scenarios

Behavior observed on latest Arduino IDE and CLI.

Related links

Arduino forum thread: https://forum.arduino.cc/t/arduino-cli-and-nano-esp32-cant-upload/
Same PR for main branch: #9666

Setting programmer.default has unfortunately multiple effects:
- sets the tick by default in the Tool menu in the IDE (which was the
  expected behavior),
- forces the CLI to use the specified programmer every time an upload is
  attempted (which is confusing users).

For this reason, it is better to remove the "programmer.default" setting
from the board definition and let the user choose the programmer in the
IDE menus, as it was before.
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label May 22, 2024
@me-no-dev me-no-dev merged commit 5e19e08 into espressif:release/v2.x May 22, 2024
49 of 50 checks passed
@VojtechBartoska VojtechBartoska added this to the 2.0.17 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants