Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esp32): Reconnect to the network after connection loss #9958

Closed
wants to merge 1 commit into from

Conversation

alkhachatryan
Copy link

Description of Change

Updated the loop function of CameraWebServer example. Currently this software will not try to re-connect to the network if it lost once. There may be a lot of reasons - wifi router lost electricity, some noise in the radio space and much more. Now, the loop function will check for the connection, it is lost - will try to re-connect. Once re-conencted, will run the web server again.

Tests scenarios

I have 6 ESP32 AI Thinker cameras and tested on all of them.

How to test this code
  1. Connect the camer to wifi by filling the credentials and uploading to camera
  2. Wait until its connected
  3. Power off your wifi device
  4. Check the serial monitor if camera said that it's trying to reconnect
  5. Power on the wifi device
  6. Check if camera could reconnect

Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello alkhachatryan, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against e629ab0

@me-no-dev
Copy link
Member

the WiFi library can reconnect on it's own. This is not necessary.

@me-no-dev me-no-dev closed this Jul 1, 2024
@alkhachatryan
Copy link
Author

How? It doesn't reconnect on my machines. I have 6 ESP32 cameras and during experiments no one could reconnect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants