Skip to content

Commit

Permalink
Merge branch 'fix/build_failure_when_hardware_gcm_is_disabled_v5.2' i…
Browse files Browse the repository at this point in the history
…nto 'release/v5.2'

fix(mbedtls/gcm): Fix build failure when config `MBEDTLS_HARDWARE_GCM` is disabled (v5.2)

See merge request espressif/esp-idf!29067
  • Loading branch information
mahavirj committed Feb 16, 2024
2 parents 8b1c532 + 5862b98 commit b43aa04
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
2 changes: 1 addition & 1 deletion components/mbedtls/CMakeLists.txt
Expand Up @@ -234,7 +234,7 @@ if(CONFIG_MBEDTLS_HARDWARE_SHA)
)
endif()

if(CONFIG_MBEDTLS_HARDWARE_GCM OR (NOT CONFIG_SOC_AES_SUPPORT_GCM AND CONFIG_MBEDTLS_HARDWARE_AES))
if(CONFIG_MBEDTLS_HARDWARE_GCM OR CONFIG_MBEDTLS_HARDWARE_AES)
target_sources(mbedcrypto PRIVATE "${COMPONENT_DIR}/port/aes/esp_aes_gcm.c")
endif()

Expand Down
8 changes: 2 additions & 6 deletions components/mbedtls/port/aes/dma/esp_aes.c
Expand Up @@ -53,10 +53,6 @@
#include "freertos/FreeRTOS.h"
#include "freertos/semphr.h"

#if SOC_AES_SUPPORT_GCM
#include "aes/esp_aes_gcm.h"
#endif

#if SOC_AES_GDMA
#define AES_LOCK() esp_crypto_sha_aes_lock_acquire()
#define AES_RELEASE() esp_crypto_sha_aes_lock_release()
Expand Down Expand Up @@ -488,7 +484,7 @@ static int esp_aes_process_dma(esp_aes_context *ctx, const unsigned char *input,
}


#if SOC_AES_SUPPORT_GCM
#if CONFIG_MBEDTLS_HARDWARE_GCM

/* Encrypt/decrypt with AES-GCM the input using DMA
* The function esp_aes_process_dma_gcm zeroises the output buffer in the case of following conditions:
Expand Down Expand Up @@ -623,7 +619,7 @@ int esp_aes_process_dma_gcm(esp_aes_context *ctx, const unsigned char *input, un
return ret;
}

#endif //SOC_AES_SUPPORT_GCM
#endif //CONFIG_MBEDTLS_HARDWARE_GCM

static int esp_aes_validate_input(esp_aes_context *ctx, const unsigned char *input,
unsigned char *output )
Expand Down
6 changes: 3 additions & 3 deletions components/mbedtls/port/aes/esp_aes_gcm.c
Expand Up @@ -371,7 +371,7 @@ int esp_aes_gcm_starts( esp_gcm_context *ctx,
/* H and the lookup table are only generated once per ctx */
if (ctx->gcm_state == ESP_AES_GCM_STATE_INIT) {
/* Lock the AES engine to calculate ghash key H in hardware */
#if SOC_AES_SUPPORT_GCM
#if CONFIG_MBEDTLS_HARDWARE_GCM
esp_aes_acquire_hardware();
ctx->aes_ctx.key_in_hardware = aes_hal_setkey(ctx->aes_ctx.key, ctx->aes_ctx.key_bytes, mode);
aes_hal_mode_init(ESP_AES_BLOCK_MODE_GCM);
Expand Down Expand Up @@ -529,7 +529,7 @@ int esp_aes_gcm_finish( esp_gcm_context *ctx,
return esp_aes_crypt_ctr(&ctx->aes_ctx, tag_len, &nc_off, ctx->ori_j0, stream, ctx->ghash, tag);
}

#if SOC_AES_SUPPORT_GCM
#if CONFIG_MBEDTLS_HARDWARE_GCM
/* Due to restrictions in the hardware (e.g. need to do the whole conversion in one go),
some combinations of inputs are not supported */
static bool esp_aes_gcm_input_support_hw_accel(size_t length, const unsigned char *aad, size_t aad_len,
Expand Down Expand Up @@ -607,7 +607,7 @@ int esp_aes_gcm_crypt_and_tag( esp_gcm_context *ctx,
size_t tag_len,
unsigned char *tag )
{
#if SOC_AES_SUPPORT_GCM
#if CONFIG_MBEDTLS_HARDWARE_GCM
int ret;
lldesc_t aad_desc[2] = {};
lldesc_t *aad_head_desc = NULL;
Expand Down

0 comments on commit b43aa04

Please sign in to comment.