refactor(dhcpserver): allow user to allocate DHCP Option 114 buffer

espressif · Apr 9, 2024 · ece07c8 · ece07c8
1 parent e3938fc
commit ece07c8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/components/esp_netif/lwip/esp_netif_lwip.c b/components/esp_netif/lwip/esp_netif_lwip.c
@@ -2335,10 +2335,7 @@ esp_err_t esp_netif_dhcps_option_api(esp_netif_api_msg_t *msg)
                 break;
             }
             case ESP_NETIF_CAPTIVEPORTAL_URI: {
-                /* unlike other flags/constant-sized IP addresses, we need to allocate for the URI */
-                char* captiveportal_uri = (char*) malloc((opt->len + 1) * sizeof(char));
-                strcpy(captiveportal_uri, opt->val);
-                opt_info = captiveportal_uri;
+                opt_info = (char *)opt->val;
                 break;
             }
 

diff --git a/examples/protocols/http_server/captive_portal/main/main.c b/examples/protocols/http_server/captive_portal/main/main.c
@@ -90,7 +90,7 @@ static void dhcp_set_captiveportal_url(void) {
     ESP_LOGI(TAG, "Set up softAP with IP: %s", ip_addr);
 
     // turn the IP into a URI
-    char captiveportal_uri[32];
+    char* captiveportal_uri = (char*) malloc(32 * sizeof(char));
     strcpy(captiveportal_uri, "http://");
     strcat(captiveportal_uri, ip_addr);