Merge branch 'fix/runtool_crcrlf_v5.1' into 'release/v5.1'

fix: save RunTool command output with correct line endings (v5.1)

See merge request espressif/esp-idf!28678

tools/idf_py_actions/tools.py

@@ -1,4 +1,4 @@
-# SPDX-FileCopyrightText: 2022-2023 Espressif Systems (Shanghai) CO LTD
+# SPDX-FileCopyrightText: 2022-2024 Espressif Systems (Shanghai) CO LTD
 # SPDX-License-Identifier: Apache-2.0
 import asyncio
 import importlib
@@ -8,7 +8,6 @@
 import subprocess
 import sys
 from asyncio.subprocess import Process
-from io import open
 from pkgutil import iter_modules
 from types import FunctionType
 from typing import Any, Dict, Generator, List, Match, Optional, TextIO, Tuple, Union
@@ -396,7 +395,11 @@ async def read_interactive_stream() -> Optional[str]:
         last_line = ''
 
         try:
-            with open(output_filename, 'w', encoding='utf8') as output_file:
+            # The command output from asyncio stream already contains OS specific line ending,
+            # because it's read in as bytes and decoded to string. On Windows "output" already
+            # contains CRLF. Use "newline=''" to prevent python to convert CRLF into CRCRLF.
+            # Please see "newline" description at https://docs.python.org/3/library/functions.html#open
+            with open(output_filename, 'w', encoding='utf8', newline='') as output_file:
                 while True:
                     if self.interactive:
                         output = await read_interactive_stream()