Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'idf.py -B MyBuildDir all' creates folder called 'mybuilddir' (all lower-case) (IDFGH-8858) #10282

Closed
3 tasks done
JBHunterI opened this issue Dec 1, 2022 · 0 comments
Closed
3 tasks done
Assignees
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Bug bugs in IDF

Comments

@JBHunterI
Copy link

Answers checklist.

  • I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
  • I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.

ESP-IDF v5.0.0

Operating System used.

Windows

How did you build your project?

Command line with idf.py

If you are using Windows, please specify command line type.

CMD

What is the expected behavior?

> cd %userprofile%\esp
> xcopy /e /i %IDF_PATH%\examples\get-started\hello_world hello_world
> cd %userprofile%\esp\hello_world
> idf.py -B MyBuildDir set-target esp32c3 <-- specified build directory name contains upper- & lower-case letters
Adding "set-target"'s dependency "fullclean" to list of commands with default set of options.
Executing action: fullclean
Build directory '%userprofile%\esp\hello_world\mybuilddir' not found. Nothing to clean. <-- build directory name changed to all lower-case letters
Executing action: set-target
Set Target to: esp32c3, new sdkconfig created. Existing sdkconfig renamed to sdkconfig.old.
Running cmake in directory %userprofile%\esp\hello_world\mybuilddir <-- build directory name changed to all lower-case letters
...

What is the actual behavior?

> cd %userprofile%\esp
> xcopy /e /i %IDF_PATH%\examples\get-started\hello_world hello_world
> cd %userprofile%\esp\hello_world
> idf.py -B MyBuildDir set-target esp32c3 <-- specified build directory name contains upper- & lower-case letters
Adding "set-target"'s dependency "fullclean" to list of commands with default set of options.
Executing action: fullclean
Build directory '%userprofile%\esp\hello_world\MyBuildDir' not found. Nothing to clean. <-- build directory name as specified
Executing action: set-target
Set Target to: esp32c3, new sdkconfig created. Existing sdkconfig renamed to sdkconfig.old.
Running cmake in directory %userprofile%\esp\hello_world\MyBuildDir <-- build directory name as specified, i.e. unchanged
...

Steps to reproduce.

  1. See "expected behavior" section above.

Build or installation Logs.

No response

More Information.

No response

@JBHunterI JBHunterI added the Type: Bug bugs in IDF label Dec 1, 2022
@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 1, 2022
@github-actions github-actions bot changed the title 'idf.py -B MyBuildDir all' creates folder called 'mybuilddir' (all lower-case) 'idf.py -B MyBuildDir all' creates folder called 'mybuilddir' (all lower-case) (IDFGH-8858) Dec 1, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Dec 16, 2022
@espressif-bot espressif-bot added Resolution: Done Issue is done internally Status: Done Issue is done internally and removed Status: In Progress Work is in progress labels Jan 18, 2023
espressif-bot pushed a commit that referenced this issue Feb 5, 2023
This commit fixes an issue where paths on Windows are case insensitive, for instance when setting the build folder its name would be converted to lowercase.

The culprit is our realpath() function, that was calling os.path.normcase() internally, since we are removing that call it makes sense to just remove the function entirely and call os.path.realpath() wherever necessary.

Closes #10282
espressif-bot pushed a commit that referenced this issue Mar 4, 2023
This commit fixes an issue where paths on Windows are case insensitive, for instance when setting the build folder its name would be converted to lowercase.

The culprit is our realpath() function, that was calling os.path.normcase() internally, since we are removing that call it makes sense to just remove the function entirely and call os.path.realpath() wherever necessary.

Closes #10282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Bug bugs in IDF
Projects
None yet
Development

No branches or pull requests

3 participants