esp_https_ota_finish does not return errors correctly (IDFGH-11510)

[huhaifan]

Answers checklist.

• I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
• I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
• I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.

v5.1.2-89-g5c61c89308

Espressif SoC revision.

ESP32-S2FNR2 (revision v1.0)

Operating System used.

Linux

How did you build your project?

VS Code IDE

If you are using Windows, please specify command line type.

None

Development Kit.

Custom Board

Power Supply used.

Battery

What is the expected behavior?

When esp_ota_set_boot_partition encounters an error, it is desired for esp_https_ota_finish to return correctly.

What is the actual behavior?

esp_https_ota_finish just return ESP_OK

Steps to reproduce.

Call OTA without otadata partition

Debug Logs.

No response

More Information.

No response

[mahavirj]

@huhaifan

Could you please try removing esp_err_t prefix from following line in the code:

esp-idf/components/esp_https_ota/src/esp_https_ota.c

Line 668 in a7fbf45

esp_err_t err = esp_ota_set_boot_partition(handle->update_partition);

[huhaifan]

@huhaifan

Could you please try removing esp_err_t prefix from following line in the code:

esp-idf/components/esp_https_ota/src/esp_https_ota.c

Line 668 in a7fbf45

esp_err_t err = esp_ota_set_boot_partition(handle->update_partition);

Yes,I have removed esp_err_t from my local esp-idf.