Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TW#16581] Potentially confusing change of dhcps default behaviour in cf7ae81 #1285

Closed
Eroc33 opened this issue Nov 18, 2017 · 2 comments
Closed

Comments

@Eroc33
Copy link

Eroc33 commented Nov 18, 2017

Commit cf7ae81 changed dhcps to allow setting a custom dns server, however this seems to have changed the default behaviour for assigning dns ips over dhcp.
Previously the default behaviour was to use the ip of the device itself as the dns server, whereas now the default is to use the ip 0.0.0.0.
I suspect this may have broken captive portal code for many people (particularly if they are using the pattern common in tutorials/examples for arduino-esp32).
While the fix to user code would be relatively minor it seems like changing the default here in the idf is probably as simple as changing https://github.com/espressif/esp-idf/blob/master/components/lwip/apps/dhcpserver.c#L97 to be static dhcps_offer_t dhcps_dns = 0x00;

@FayeY FayeY changed the title Potentially confusing change of dhcps default behaviour in cf7ae81 [TW#16581] Potentially confusing change of dhcps default behaviour in cf7ae81 Nov 21, 2017
@liuzfesp
Copy link
Contributor

Hi @Eroc33 we will check it and make sure the default behavior is not changed @zhangyanjiaoesp

@zhangyanjiaoesp
Copy link
Collaborator

@Eroc33 Thanks for your good suggestion.
I have modify the code ,after it is merged ,I will post the commit ID

@igrr igrr closed this as completed in e315d7c Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants