Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error when CONFIG_ESP_CONSOLE_NONE=y (IDFGH-11900) #12984

Closed
3 tasks done
AxelLin opened this issue Jan 16, 2024 · 4 comments
Closed
3 tasks done

Compile error when CONFIG_ESP_CONSOLE_NONE=y (IDFGH-11900) #12984

AxelLin opened this issue Jan 16, 2024 · 4 comments
Assignees
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Type: Bug bugs in IDF

Comments

@AxelLin
Copy link
Contributor

AxelLin commented Jan 16, 2024

Answers checklist.

  • I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
  • I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.

v5.3-dev-1353-gb3f7e2c8a4

Operating System used.

Linux

How did you build your project?

Command line with idf.py

If you are using Windows, please specify command line type.

None

What is the expected behavior?

Build should work with CONFIG_ESP_CONSOLE_NONE=y.

What is the actual behavior?

/home/axel/esp/esp-idf/components/vfs/vfs_console.c: In function 'esp_vfs_console_register':
/home/axel/esp/esp-idf/components/vfs/vfs_console.c:210:35: error: 'primary_path' undeclared (first use in this function); did you mean 'primary_vfs'?
210 | err = esp_vfs_register_common(primary_path, strlen(primary_path), primary_vfs, NULL, &primary_vfs_index);
| ^~~~~~~~~~~~
| primary_vfs
/home/axel/esp/esp-idf/components/vfs/vfs_console.c:210:35: note: each undeclared identifier is reported only once for each function it appears in
[514/1450] Building C object esp-idf/driver/CMakeFiles/__idf_driver.dir/deprecated/rmt_legacy.c.obj
ninja: build stopped: subcommand failed.

Steps to reproduce.

Build for ESP32C6 with CONFIG_ESP_CONSOLE_NONE=y.

Build or installation Logs.

No response

More Information.

No response

@AxelLin AxelLin added the Type: Bug bugs in IDF label Jan 16, 2024
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 16, 2024
@github-actions github-actions bot changed the title Compile error when CONFIG_ESP_CONSOLE_NONE=y Compile error when CONFIG_ESP_CONSOLE_NONE=y (IDFGH-11900) Jan 16, 2024
@AxelLin
Copy link
Contributor Author

AxelLin commented Jan 16, 2024

BTW, I also got below build warnings when CONFIG_ESP_CONSOLE_NONE=y

[429/938] Building C object esp-idf/console/CMakeFiles/__idf_console.dir/esp_console_repl.c.obj
/home/axel/esp/esp-idf/components/console/esp_console_repl.c:476:13: warning: 'esp_console_repl_task' defined but not used [-Wunused-function]
476 | static void esp_console_repl_task(void *args)
| ^~~~~~~~~~~~~~~~~~~~~
/home/axel/esp/esp-idf/components/console/esp_console_repl.c:372:18: warning: 'esp_console_common_init' defined but not used [-Wunused-function]
372 | static esp_err_t esp_console_common_init(size_t max_cmdline_length, esp_console_repl_com_t *repl_com)
| ^~~~~~~~~~~~~~~~~~~~~~~
/home/axel/esp/esp-idf/components/console/esp_console_repl.c:351:18: warning: 'esp_console_setup_history' defined but not used [-Wunused-function]
351 | static esp_err_t esp_console_setup_history(const char *history_path, uint32_t max_history_len, esp_console_repl_com_t *repl_com)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
/home/axel/esp/esp-idf/components/console/esp_console_repl.c:326:18: warning: 'esp_console_setup_prompt' defined but not used [-Wunused-function]
326 | static esp_err_t esp_console_setup_prompt(const char *prompt, esp_console_repl_com_t *repl_com)
| ^~~~~~~~~~~~~~~~~~~~~~~~

@Dazza0
Copy link
Collaborator

Dazza0 commented Jan 16, 2024

@AxelLin Thanks for reporting this issue, will take a look.

@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development and removed Status: Opened Issue is new labels Jan 17, 2024
@AxelLin
Copy link
Contributor Author

AxelLin commented Feb 13, 2024

@Dazza0
I thought a compile error should be fixed ASAP.
Do you have target timeline to fix this?

@AxelLin
Copy link
Contributor Author

AxelLin commented Feb 27, 2024

@Dazza0 @igrr
Is it really difficult to fix this compile error?
I don't expect such long time for a compile fix.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Selected for Development Issue is selected for development labels Feb 29, 2024
espressif-bot pushed a commit that referenced this issue Mar 5, 2024
This commit fixes the following build issues when CONFIG_ESP_CONSOLE_NONE is
enabled:

- esp_console_repl.c will have 'defined but unused' warnings on various console
functions.
- esp_console_repl.c does not use "TAG" when CONFIG_ESP_CONSOLE_NONE is
enabled, leading to a "defined by not used" warning.

Closes #12984
espressif-bot pushed a commit that referenced this issue Mar 6, 2024
This commit fixes the following build issues when CONFIG_ESP_CONSOLE_NONE is
enabled:

- esp_console_repl.c will have 'defined but unused' warnings on various console
functions.
- esp_console_repl.c does not use "TAG" when CONFIG_ESP_CONSOLE_NONE is
enabled, leading to a "defined by not used" warning.

Closes #12984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Type: Bug bugs in IDF
Projects
None yet
Development

No branches or pull requests

3 participants