Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TW#17970] LWIP update #1512

Closed
zafrirron opened this issue Jan 16, 2018 · 20 comments
Closed

[TW#17970] LWIP update #1512

zafrirron opened this issue Jan 16, 2018 · 20 comments

Comments

@zafrirron
Copy link

Hi
Looking at LWIP version, you are using old version, lots of changes since you import LWIP,
would you consider updatating LWIP?
(not sure how many customizations done...)

@hchaudhary1
Copy link

@zafrirron are you looking for a particular feature?

@zafrirron
Copy link
Author

Looking to port HomeKit protocol support github project that requires newer LWIP according to the project writer.

@FayeY
Copy link
Collaborator

FayeY commented Jan 23, 2018

Hi @zafrirron , the ESP32 has already supported Homekit, but it is not open on the github, you can send a request for ESP32 Homekit SDK on the ESP website.
Thanks.

@FayeY FayeY closed this as completed Jan 23, 2018
@renssies
Copy link

@FayeY don't close this too quickly. The SDK you are referring too is for MFI licensees only and Espressif has said to have no plans for a non-commercial SDK. So hobbyists are creating their own SDK for the ESP32.

Since WWDC 2017 there is a Non-commercial HomeKit spec for Hobbyist, Enthusiasts, and prototyping without needing a license. People have already created an SDK for the ESP8266 (https://github.com/maximkulkin/esp-homekit). They want to port this to the ESP32, however, this can not be done due too LWIP being out of date and therefor missing features.

So until Espressif decides to also open an SDK for non-commercial use, you should still consider updating LWIP

@FayeY FayeY reopened this Jan 29, 2018
@FayeY FayeY changed the title LWIP update [TW#17970] LWIP update Jan 29, 2018
@zafrirron
Copy link
Author

zafrirron commented Jan 29, 2018

Thanks @renssies,
I did not expect such answer from @FayeY, thought he understands most users here and ESP32 IDF current state, we all in development and prototyping stages, so sending me to MFI option.... was disappointing 👎:-( did not bother to answer).

@FayeY
Copy link
Collaborator

FayeY commented Jan 29, 2018

Hi both,
Sorry for the misunderstanding before.
This issue has been reopened and assigned to our engineers internally, we will evaluate this request.
Thanks for your interest in ESP32!

@affonsoloyola
Copy link

Same thing here. Trying to prototype something that needs newer features os LWIP.
I tried to get the HomeKit SDK with Espressif support but they said it’s only available for MFi licenced companies. Please update LWIP. That version is too old!

@goldsimon
Copy link

While you're at it, you could try to minimize the changes to upstream sources so that updating lwIP would be a simple matter of updating the sources and recompiling. lwIP tries to be compatible and/or simple to upgrade, so this should not be too hard as long as the sources are kept clean.

Also: a) some of the local changes seem bogus and should not be required and b) for things that are real bugs, it would be nice to get them reported back to the lwIP project.

@zhangyanjiaoesp
Copy link
Collaborator

@zafrirron@hchaudhary1@renssies@affonsoloyola@goldsimon
Recently we are updating our LWIP to the offical v2.0.3, but it will take some time for the system to work stablely

@goldsimon
Copy link

That's great news! May I suggest again to work with the lwIP project (I'm the maintainer of that stack) to get you a clean copy of the stack? That will also make it easier to integrate new releases, as there should be no stability issues otherwise (when upgrading a clean lwIP stack).

Just post your questions or issues to the lwip-devel@nongnu.org mailing list.

@zhangyanjiaoesp
Copy link
Collaborator

@goldsimon yes, you are right ! we are doing what you said exactlly.

@jukorp
Copy link

jukorp commented Mar 15, 2018

i'm looking forward to the new lwip 2.0.3 version.
Estimate when ready?

@zaninime
Copy link

I'm also waiting on this. Anything I can do to help? Thanks!

@jpan127
Copy link

jpan127 commented Apr 21, 2018

Another bump (to show this would be appreciated).

@ourairquality
Copy link

I would also like to see a sync to the upstream lwip. The esp-open-rtos has been following the upstream lwip and attempting to contribute changes upstream. It would make it easier to port code across these development environments. Is someone planning to work on this, or is it waiting for a contribution?

@jeffsenn
Copy link

Big +1 on this. I just spent the day finding and fixing a leak (LWIP Bug #51937) that has already been fixed "upstream".

NZSmartie pushed a commit to NZSmartie/esp-idf that referenced this issue Jul 15, 2018
Attempt to fix espressif#1512 by upstreaming the library instead of a untracked copy
NZSmartie added a commit to NZSmartie/esp-idf that referenced this issue Jul 15, 2018
Attempt to fix espressif#1512 by upstreaming the library instead of a untracked copy
@NZSmartie
Copy link

I've started a fork where i've removed Espressif's copy of LWIP in favour of using @goldsimon's version hosted on nongnu,org. The build does compile with "Copy L2 to L3" enabled under both LWIP and Ethernet component configuration options.

Modifications have/are being done to components of ESP-IDF to support the new LWIP and I've found quite a few redundancies with developers reimplementing code that already exists in LWIP. Hopefully once it's all done, keeping LWIP up to date will be as easy as git pull within components/lwip/lwip

Please note that not all configuration options have been tested yet, but i hope to have that done in the next week.

@twelve12pm
Copy link

Big +1 on using clean upstream lwIP!

@comcomservices
Copy link

@NZSmartie, using your fork! Thanks a ton!

@zhangyanjiaoesp
Copy link
Collaborator

zhangyanjiaoesp commented Sep 7, 2018

Hi all, sorry for replying later.
The lwIP in ESP-IDF has been updated based on the offical stable version 2.0.3 in the latest master.
And the lwIP is as a submodule in ESP-IDF now, you can find the esp-lwip here

@FayeY FayeY closed this as completed Sep 7, 2018
0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-idf that referenced this issue May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests