-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TW#26442] Automatic light sleep crashes randomly #2459
Comments
I tried to revert that commit one small bit at a time, to find the error, but I could not get the My next step would be reverting the entire commit properly, with git (instead of piecemeal). And maybe confirm the git bisect result. I'll hold off on that for a bit, to see where you guys are at. |
It works! The linked patch above resolved my My project is doing a deployment, and we need this patch. This is a vote to merge this to master and do a tagged minor release (3.1.1 maybe?). Which is to say, this seems worthy of a bugfix release...? Thank you! |
@dereks This fix will be in master branch soon. My understanding is that the regression is only in master branch, not in v3.1. Please let me know if you see this in v3.1 as well. |
For me, there's differing results for wifi/power_save example and the short snippet pasted in the ticket for v3.1. For master (11b444b), neither works (obviously as that's the gist of the ticket). release/v3.1 wifi/power_save: works master+patch wifi/power_save: works So there's something in v3.1 that's still broken that manifests differently between the snippet and the wifi/power_save example. |
Okay I spoke too soon, the test snippet is still broken for me on master(11b444b) + patch |
|
@erkki |
Sure thing, here's a minimal example (needs to be modified a bit for v3.1 for the pm parts). |
@erkki |
Okay I'm a dummy, the new minimal example I generated used a blank sdkconfig with power management turned off. The patched version works now. |
I will try to test it sometime this week. The app I inherited was using an old master HEAD (pre 3.1), so I just did a git pull. I know it's bad to use master in a deployment, but you guys have added an amazing number of bug fixes and feature improvements in just the last few days -- I think we will want those in our deployed image. We have OTA available so there is some risk mitigation (not counting a bricking bug). But of course tagged official releases are what one should usually use. |
Closes: espressif/esp-idf#2459 Signed-off-by: Mahavir Jain <mahavir@espressif.com>
Environment
git rev-parse --short HEAD
to get the commit id.): 3276a13Problem Description
Auto light sleep seems to crash randomly, both in a minimal test case and the wifi power save example. Tested on 2 different esp-wroom-32 kits on both usb power and battery power. In the minimal sample case, reducing vTaskDelay to 30ms seems to work fine while anything up from 40ms and larger constantly crashes, with differing error results, either WDT reboots or memory load/store errors.
Testing with release/v3.1, the wifi power save example works. Git bisect got to commit ff81dc1 as the first bad commit.
Code to reproduce this issue
The wifi power save example or the following:
Debug Logs
The text was updated successfully, but these errors were encountered: