Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI_FLASH_WRITING_DANGEROUS_REGIONS is broken in menuconfig/genconfig (IDFGH-1307) #3598

Closed
ducalex opened this issue Jun 6, 2019 · 2 comments

Comments

@ducalex
Copy link

ducalex commented Jun 6, 2019

Environment

  • Development Kit: ESP32-Wrover-Kit
  • Kit version (for WroverKit/PicoKit/DevKitC):
  • Module or chip used: ESP32
  • IDF version (run git describe --tags to find it): v3.3-beta1-728-g8c57aa024
  • Build System: Make
  • Compiler version (run xtensa-esp32-elf-gcc --version to find it):
    // (crosstool-NG crosstool-ng-1.22.0-80-g6c4433a5) 5.2.0
  • Operating System: Windows
  • Power Supply: USB

Problem Description

CONFIG_SPI_FLASH_WRITING_DANGEROUS_REGIONS_ALLOWED is no longer available.

In commit 37126d3 the indentation in components/spi_flash/Kconfig was messed up and it's now impossible to allow the option.

Expected Behavior

Have a choice of Aborts/Fails/Allowed

Actual Behavior

No choice

Steps to repropduce

  1. Make menuconfig
  2. Go to Components -> SPI Flash
  3. See Writing to dangerous flash regions item

Code to reproduce this issue

None

Debug Logs

None

Other items if possible

None

@github-actions github-actions bot changed the title CONFIG_SPI_FLASH_WRITING_DANGEROUS_REGIONS_* is broken in menuconfig/genconfig CONFIG_SPI_FLASH_WRITING_DANGEROUS_REGIONS_* is broken in menuconfig/genconfig (IDFGH-1307) Jun 6, 2019
@ducalex ducalex changed the title CONFIG_SPI_FLASH_WRITING_DANGEROUS_REGIONS_* is broken in menuconfig/genconfig (IDFGH-1307) SPI_FLASH_WRITING_DANGEROUS_REGIONS is broken in menuconfig/genconfig (IDFGH-1307) Jun 6, 2019
@dobairoland
Copy link
Collaborator

Thank you @ducalex for reporting this issue. It will be fixed ASAP.

@igrr igrr closed this as completed in 842384a Jun 13, 2019
@dobairoland
Copy link
Collaborator

Please note that this has been fixed in master and will be fixed with a little delay in v3.3 as well. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants