Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"channel" parameter should be of "ledc_channel_t" #54

Closed
nkolban opened this issue Oct 14, 2016 · 0 comments
Closed

"channel" parameter should be of "ledc_channel_t" #54

nkolban opened this issue Oct 14, 2016 · 0 comments
Labels
Status: In Progress Work is in progress

Comments

@nkolban
Copy link
Contributor

nkolban commented Oct 14, 2016

If we look in ledc.h here:

esp-idf/components/driver/include/driver/ledc.h

Line 245 in f80ed0f

esp_err_t ledc_set_fade(ledc_mode_t speed_mode, uint32_t channel, uint32_t duty, ledc_duty_direction_t gradule_direction,

We find that the channel parameter is defined is uint32_t. I believe it should be defined as ledc_channel_t.
@projectgus projectgus added the Status: In Progress Work is in progress label Dec 22, 2016
igrr pushed a commit that referenced this issue Dec 29, 2016
@projectgus
LEDC driver: Use ledc_channel_t for all channel arguments
45571b3 
Closes github #54: #54
@igrr igrr removed the Status: In Progress Work is in progress label Jan 16, 2017
@rokmarko rokmarko mentioned this issue Nov 9, 2021
Closed
mikkeldamsgaard pushed a commit to mikkeldamsgaard/esp-idf that referenced this issue Mar 26, 2022
@erikcorry
Add non-blocking UART write functions (espressif#54)
79e37ed
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 6, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Aug 15, 2022
mikkeldamsgaard pushed a commit to mikkeldamsgaard/esp-idf that referenced this issue Sep 28, 2022
@erikcorry @floitsch
Add non-blocking UART write functions (espressif#54)
9bc034d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: In Progress Work is in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@projectgus @nkolban @igrr @espressif-bot