Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TW#12228] sntp example code bug #549

Closed
rillhu opened this issue Apr 28, 2017 · 0 comments
Closed

[TW#12228] sntp example code bug #549

rillhu opened this issue Apr 28, 2017 · 0 comments

Comments

@rillhu
Copy link

rillhu commented Apr 28, 2017

In example at this path esp-idf\examples\protocols\sntp, when it tries to get the "Shanghai" time, the time zone actually is wrongly set.
Currently it is
setenv("TZ", "CST-8CDT-9,M4.2.0/2,M9.2.0/3", 1);
However it should be CST-8CDT-8, I suggest correct this tiny bug.
@FayeY FayeY changed the title sntp example code bug [TW#12228] sntp example code bug May 3, 2017
@igrr igrr closed this as completed in 4c01929 May 8, 2017
igrr added a commit that referenced this issue May 8, 2017
@igrr
Merge branch 'bugfix/sntp_timezone' into 'master'
8e3c30a 
examples: fix timezone for China in SNTP example

Daylight saving time isn’t observed in China.

Fixes #549

See merge request !722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rillhu