Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PVS-Studio: 71 issues (IDFGH-4626) #6440

Closed
AndreyKarpov opened this issue Jan 20, 2021 · 5 comments
Closed

PVS-Studio: 71 issues (IDFGH-4626) #6440

AndreyKarpov opened this issue Jan 20, 2021 · 5 comments
Assignees
@zikalino
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@AndreyKarpov
Copy link

One of our readers recommended paying heed to the Espressif IoT Development Framework. He found an error in the project code and asked if the PVS-Studio static analyzer could find it. The analyzer can't detect this specific error so far, but it managed to spot many others: https://www.viva64.com/en/b/0790/
@github-actions github-actions bot changed the title PVS-Studio: 71 issues PVS-Studio: 71 issues (IDFGH-4626) Jan 20, 2021
@megazhuk
Copy link

How to get more attention to this issues?
I think this is important, since developers can fix 71 errors at once in 1 day.

@projectgus
Copy link
Contributor

Hi @AndreyKarpov,

Thanks for opening the issue to let us know about your analysis work and blog post. We're in the process of analyzing your results and dividing the tasks up between the various subsystems that are affected. This issue will be updated as soon as we start applying fixes.

In a few cases it seems like the analyser may have returned some false positives. For example, in the case of the static function _mdns_dup_interface "array index out of bounds", the caller has always pre-checked the result of _mdns_get_other_if() before calling _mdns_dup_interface()).

In other cases your analysis has clearly found bugs, so thank you again for bringing them to our attention.

projectgus pushed a commit that referenced this issue Feb 10, 2021
@AdityaHPatwardhan @espressif-bot
esp_tls: Fix misplaced paranthesis in esp_tls_mbedtls.c
0175c68 
Fixes one part of -  #6440
projectgus pushed a commit that referenced this issue Feb 10, 2021
@AdityaHPatwardhan @espressif-bot
protocomm: Fixed NULL check of allocated memory
d364797 
Fixes one part of - #6440
david-cermak added a commit to espressif/esp-mqtt that referenced this issue Feb 11, 2021
@david-cermak
Config: Add missing nullcheck after cfg password allocation
001dc1a 
Partially addresses espressif/esp-idf#6440
@mahavirj mahavirj mentioned this issue Feb 25, 2021
Merged
espressif-bot pushed a commit that referenced this issue Mar 7, 2021
@AdityaHPatwardhan
esp_tls: Fix misplaced paranthesis in esp_tls_mbedtls.c
b827449 
Fixes one part of -  #6440
espressif-bot pushed a commit that referenced this issue Mar 7, 2021
@AdityaHPatwardhan
protocomm: Fixed NULL check of allocated memory
5b215db 
Fixes one part of - #6440
espressif-bot pushed a commit that referenced this issue Mar 9, 2021
@AdityaHPatwardhan
esp_tls: Fix misplaced paranthesis in esp_tls_mbedtls.c
a2e6db1 
Fixes one part of -  #6440
espressif-bot pushed a commit that referenced this issue Mar 9, 2021
@AdityaHPatwardhan
protocomm: Fixed NULL check of allocated memory
a2ccb3c 
Fixes one part of - #6440
espressif-bot pushed a commit that referenced this issue Mar 11, 2021
@AdityaHPatwardhan
esp_tls: Fix misplaced paranthesis in esp_tls_mbedtls.c
d61ee58 
Fixes one part of -  #6440
espressif-bot pushed a commit that referenced this issue Mar 11, 2021
@AdityaHPatwardhan
protocomm: Fixed NULL check of allocated memory
962ea61 
Fixes one part of - #6440
projectgus pushed a commit that referenced this issue Mar 12, 2021
@AdityaHPatwardhan
protocomm: Fixed NULL check of allocated memory
2803e6b 
Fixes one part of - #6440
espressif-bot pushed a commit that referenced this issue Mar 12, 2021
@ESP-Marius @espressif-bot
freertos: fix errors reported by PVS-Studio
d294ac3 
Removed leftover code-paths that were never taken. Upstream freertos uses
vTaskSuspendAll() and xTaskResumeAll(), and therefor check if the task already
yielded.

In the IDF port of freertos we use critcal sections instead, so xAlreadyYielded
will never be set.

Partially addresses #6440
espressif-bot pushed a commit that referenced this issue Mar 12, 2021
@suren-gabrielyan-espressif @espressif-bot
mdns: add bound check when setting interface as duplicate
2b9d2c0 
Closes IDF-2787

Partially addresses #6440
espressif-bot pushed a commit that referenced this issue Mar 12, 2021
@AdityaHPatwardhan
coap: Fixed NULL checks for dymanic memory allocation in coap_mbedtls.c
3e533be 
Fixes one part of - #6440
espressif-bot pushed a commit that referenced this issue Apr 27, 2021
@mahavirj @espressif-bot
tinycbor: update to latest upstream commit-id
6a06be0 
Relevant: #6440

Closes IDF-2792
@zikalino zikalino self-assigned this Mar 8, 2022
@zikalino
Copy link
Collaborator

zikalino commented Mar 8, 2022

For some reason this issue was forgotten and all the problems should be reviewed properly.

espressif-bot pushed a commit that referenced this issue Mar 18, 2022
@igrr
console: linenoise: fix usage of an uninitialized buffer
eab33e7 
Reported in #6440

The issue could occur if esp_console_config_t::hint_color
was set to -1.
espressif-bot pushed a commit that referenced this issue Mar 18, 2022
@igrr
gdbstub: fix array overrun
fdef8ae 
https://pvs-studio.com/en/blog/posts/cpp/0790/#ID487F9D1F5B
Reported in #6440
espressif-bot pushed a commit that referenced this issue Mar 18, 2022
@igrr
spi_flash, newlib: fix NULL pointer dereference on OOM
4aa2719 
https://pvs-studio.com/en/blog/posts/cpp/0790/#ID88049D3FA2
Reported in #6440
@igrr
Copy link
Member

igrr commented Mar 18, 2022

wpa_supplicant fixes applied in 6da52cf (forgot to add a link back to this issue)

@espressif-bot espressif-bot added Resolution: Done Issue is done internally Status: Done Issue is done internally labels Mar 22, 2022
@igrr
Copy link
Member

igrr commented Mar 22, 2022

The final fixes for driver, essl and hal have been merged and will be synced to Github soon.
Thanks again for finding and explaining these issues in detail!

@igrr igrr closed this as completed Mar 22, 2022
espressif-bot pushed a commit that referenced this issue Mar 23, 2022
@igrr
driver: fix issues reported by PVS-Studio
0fe3281 
https://www.viva64.com/en/b/0790/#ID88049D3FA2
https://www.viva64.com/en/b/0790/#IDE0890EE01C
Reported in #6440
espressif-bot pushed a commit that referenced this issue Mar 23, 2022
@igrr
essl: fix logical bug in argument check
6a4a6d5 
https://pvs-studio.com/en/blog/posts/cpp/0790/#IDBDD4F1FD2D
Reported in #6440
espressif-bot pushed a commit that referenced this issue Mar 23, 2022
@igrr
hal: fix issues reported by PVS-Studio
12717cb 
https://www.viva64.com/en/b/0790/#ID369075A8F4
https://www.viva64.com/en/b/0790/#IDF03E449184
Reported in #6440
david-cermak pushed a commit to david-cermak/esp-protocols that referenced this issue Mar 24, 2022
@suren-gabrielyan-espressif @david-cermak
mdns: add bound check when setting interface as duplicate
849ac67 
Closes IDF-2787

Partially addresses espressif/esp-idf#6440


* Original commit: espressif/esp-idf@2b9d2c0
gabsuren pushed a commit to gabsuren/esp-protocols-1 that referenced this issue Mar 25, 2022
@suren-gabrielyan-espressif
mdns: add bound check when setting interface as duplicate
f4e4cdc 
Closes IDF-2787

Partially addresses espressif/esp-idf#6440


* Original commit: espressif/esp-idf@2b9d2c0
gabsuren pushed a commit to gabsuren/esp-protocols-1 that referenced this issue Apr 8, 2022
@suren-gabrielyan-espressif
mdns: add bound check when setting interface as duplicate
8a850e2 
Closes IDF-2787

Partially addresses espressif/esp-idf#6440


* Original commit: espressif/esp-idf@2b9d2c0
espressif-bot pushed a commit that referenced this issue Apr 12, 2022
@igrr
console: argtable3: upgrade to v3.2.1
c0d62c5 
Source code taken from release archives in
https://github.com/argtable/argtable3/releases/tag/v3.2.1.52f24e5

Applied dos2unix to all files.
Removed trailing whitespace with the pre-commit hook.

Resolves some of the static analysis issues reported in
#6440
(mallocs are replaced by xmalloc wrapper which panics on failed
allocations)
espressif-bot pushed a commit that referenced this issue Apr 24, 2022
@igrr @mahavirj
console: linenoise: fix usage of an uninitialized buffer
c0b97b6 
Reported in #6440

The issue could occur if esp_console_config_t::hint_color
was set to -1.
espressif-bot pushed a commit that referenced this issue Apr 24, 2022
@igrr @mahavirj
console: linenoise: fix usage of an uninitialized buffer
5628f1f 
Reported in #6440

The issue could occur if esp_console_config_t::hint_color
was set to -1.
gabsuren pushed a commit to gabsuren/esp-protocols-1 that referenced this issue May 17, 2022
@suren-gabrielyan-espressif
mdns: add bound check when setting interface as duplicate
6adb246 
Closes IDF-2787

Partially addresses espressif/esp-idf#6440


* Original commit: espressif/esp-idf@2b9d2c0
gabsuren pushed a commit to gabsuren/esp-protocols-1 that referenced this issue May 27, 2022
@suren-gabrielyan-espressif
mdns: add bound check when setting interface as duplicate
ac478a2 
Closes IDF-2787

Partially addresses espressif/esp-idf#6440


* Original commit: espressif/esp-idf@2b9d2c0
gabsuren pushed a commit to gabsuren/esp-protocols-1 that referenced this issue May 27, 2022
@suren-gabrielyan-espressif
mdns: add bound check when setting interface as duplicate
8cb03d2 
Closes IDF-2787

Partially addresses espressif/esp-idf#6440


* Original commit: espressif/esp-idf@2b9d2c0
gabsuren pushed a commit to gabsuren/esp-protocols-1 that referenced this issue May 27, 2022
@suren-gabrielyan-espressif
mdns: add bound check when setting interface as duplicate
b114ed6 
Closes IDF-2787

Partially addresses espressif/esp-idf#6440


* Original commit: espressif/esp-idf@2b9d2c0
0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-protocols that referenced this issue Jun 30, 2022
@suren-gabrielyan-espressif @0xFEEDC0DE64
mdns: add bound check when setting interface as duplicate
bd262ec 
Closes IDF-2787

Partially addresses espressif/esp-idf#6440


* Original commit: espressif/esp-idf@2b9d2c0
euripedesrocha pushed a commit to euripedesrocha/esp-protocols that referenced this issue Oct 17, 2022
@suren-gabrielyan-espressif @euripedesrocha
mdns: add bound check when setting interface as duplicate
0d15ddf 
Closes IDF-2787

Partially addresses espressif/esp-idf#6440


* Original commit: espressif/esp-idf@2b9d2c0
espressif-bot pushed a commit that referenced this issue Nov 11, 2022
@igrr
console: argtable3: upgrade to v3.2.1
2c66721 
Source code taken from release archives in
https://github.com/argtable/argtable3/releases/tag/v3.2.1.52f24e5

Applied dos2unix to all files.
Removed trailing whitespace with the pre-commit hook.

Resolves some of the static analysis issues reported in
#6440
(mallocs are replaced by xmalloc wrapper which panics on failed
allocations)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zikalino zikalino

Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@projectgus @megazhuk @AndreyKarpov @igrr @zikalino @espressif-bot