Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused tag variables breaking compilation (IDFGH-6608) #8250

Closed
KaeLL opened this issue Jan 17, 2022 · 1 comment
Closed

Unused tag variables breaking compilation (IDFGH-6608) #8250

KaeLL opened this issue Jan 17, 2022 · 1 comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@KaeLL
Copy link
Contributor

KaeLL commented Jan 17, 2022

  • IDF version: release/v4.4

Actual Behavior

/esp-idf/components/esp_adc_cal/esp_adc_cal_esp32.c:86:19: error: 'LOG_TAG' defined but not used [-Werror=unused-const-variable=]
 const static char LOG_TAG[] = "ADC_CALI";
                   ^~~~~~~
cc1: some warnings being treated as errors

Steps to reproduce

hello-world with COMPILER_OPTIMIZATION_CHECKS_SILENT set
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 17, 2022
@github-actions github-actions bot changed the title Unused tag variables breaking compilation Unused tag variables breaking compilation (IDFGH-6608) Jan 17, 2022
@suda-morris
Copy link
Collaborator

Good catch, we also noticed this issue recently and already have a fix for that. Will sync the fix to master and 4.4 soon.

@espressif-bot espressif-bot added Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Jan 18, 2022
espressif-bot pushed a commit that referenced this issue Jan 29, 2022
@suda-morris
build: fix unused tag string
42abd89 
Closes #8250
dskulina pushed a commit to playable-tech/esp-idf that referenced this issue Feb 4, 2022
@suda-morris @dskulina
build: fix unused tag string
f1fc29d 
Closes espressif#8250
dskulina pushed a commit to playable-tech/esp-idf that referenced this issue Feb 5, 2022
@suda-morris @dskulina
build: fix unused tag string
f42e0b4 
Closes espressif#8250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KaeLL @suda-morris @espressif-bot