Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiFi Provisioning can't be stopped when build for release. (IDFGH-6679) #8309

Closed
Laurens-Wuyts opened this issue Jan 28, 2022 · 0 comments
Closed

WiFi Provisioning can't be stopped when build for release. (IDFGH-6679) #8309

Laurens-Wuyts opened this issue Jan 28, 2022 · 0 comments
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@Laurens-Wuyts
Copy link

Laurens-Wuyts commented Jan 28, 2022 •
edited

Environment

  • Custom Hardware
  • Module or chip used: ESP32-WROVER-I
  • IDF version (run git describe --tags to find it): v4.3
  • Build System: CMake
  • Compiler version (run xtensa-esp32-elf-gcc --version to find it): xtensa-esp32-elf-gcc (crosstool-NG esp-2020r3) 8.4.0
  • Operating System: Windows
  • (Windows only) environment type: MSYS2 mingw32.

Problem Description

When building the Wifi provisioning module in release mode (with NDEBUG defined), the task to stop provisioning is never started as it is voided together with the assert function it is called in.

esp-idf/components/wifi_provisioning/src/manager.c

Lines 626 to 627 in 84d11d1

assert(xTaskCreate(prov_stop_task, "prov_stop_task", 4096, (void *)1,
tskIDLE_PRIORITY, NULL) == pdPASS);

This assert will be converted to a (void)0 when building a release version and with this the function is also voided.
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 28, 2022
@github-actions github-actions bot changed the title WiFi Provisioning can't be stopped when build for release. WiFi Provisioning can't be stopped when build for release. (IDFGH-6679) Jan 28, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Jan 31, 2022
espressif-bot pushed a commit that referenced this issue Feb 2, 2022
@laukik-hase
wifi_prov_mgr: Fix provisioning not stopping in release mode
d29ab82 
- For the wifi_prov_mgr example in release mode (with NDEBUG defined -
  assertions disabled), the task to stop provisioning is never started
  as it is voided by the assert function it is called in.

Closes #8309
dskulina pushed a commit to playable-tech/esp-idf that referenced this issue Feb 4, 2022
@laukik-hase @dskulina
wifi_prov_mgr: Fix provisioning not stopping in release mode
ddd4d7e 
- For the wifi_prov_mgr example in release mode (with NDEBUG defined -
  assertions disabled), the task to stop provisioning is never started
  as it is voided by the assert function it is called in.

Closes espressif#8309
espressif-bot pushed a commit that referenced this issue Feb 5, 2022
@laukik-hase
wifi_prov_mgr: Fix provisioning not stopping in release mode
b7c1c49 
- For the wifi_prov_mgr example in release mode (with NDEBUG defined -
  assertions disabled), the task to stop provisioning is never started
  as it is voided by the assert function it is called in.

Closes #8309
dskulina pushed a commit to playable-tech/esp-idf that referenced this issue Feb 5, 2022
@laukik-hase @dskulina
wifi_prov_mgr: Fix provisioning not stopping in release mode
c6ee6e5 
- For the wifi_prov_mgr example in release mode (with NDEBUG defined -
  assertions disabled), the task to stop provisioning is never started
  as it is voided by the assert function it is called in.

Closes espressif#8309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Laurens-Wuyts @espressif-bot