Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of uint32_t instead of size_t for spi_flash_mmap #88

Closed
nkolban opened this issue Nov 10, 2016 · 0 comments
Closed

Use of uint32_t instead of size_t for spi_flash_mmap #88

nkolban opened this issue Nov 10, 2016 · 0 comments

Comments

@nkolban
Copy link
Contributor

nkolban commented Nov 10, 2016

Another trivial report ...

In esp_spi_flash.h we define spi_flash_mmap as:

esp_err_t spi_flash_mmap(uint32_t src_addr, size_t size, spi_flash_mmap_memory_t memory,
                         const void** out_ptr, spi_flash_mmap_handle_t* out_handle);

Notice that the first parameter is defined as uint32_t. In all the other definitions, we had defined flash address locations as size_t. This issue suggests changing the type of this function to also be size_t to maintain consistency.

@projectgus projectgus added the Status: In Progress Work is in progress label Dec 22, 2016
@igrr igrr removed the Status: In Progress Work is in progress label Jan 16, 2017
0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-idf that referenced this issue May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants